Support global http proxy config when during http jobs #2450
Conversation
|
dep PR: Commonjava/jhttpc#59 & Commonjava/galley#426 |
| @@ -10,8 +10,9 @@ | |||
| #user= | |||
|
|
|||
| ## Proxy settings | |||
| #proxy.host=http://myproxy.com | |||
| #proxy.port=8001 | |||
| proxy.host=http://proxy.squi-001.prod.iad2.dc.redhat.com | |||
There was a problem hiding this comment.
Avoid to declare this here, since we will use internal repo for this configuration.
There was a problem hiding this comment.
@sswguo Could you clarify this more? You mean this proxy.host will be used for some other purpose?
There was a problem hiding this comment.
Ah, sorry, I just mean the value, avoid to commit the redhat one, should be good with http://myproxy.com , and let's put the redhat one in our ansible script.
There was a problem hiding this comment.
@sswguo Ok, will comment it out and update the ansible later, thanks.
|
Just a tiny thing. Otherwise LGTM. |
|
@ligangty, yeah, I rebase and it seems ok now, I'm fixing another CDI issue which is not related, thanks. |
|
Just push commit#2:348b3ba, associate with Commonjava/galley#430 to fix the CDI problem. |
No description provided.