N°5139 - Let data that is null also be null at the other side-fix

[odain-cbd]

Current PR intends to enhance "Reset or untouch" option (nullified configuration) to work also for empty string ("") fields values.

During data collection, fields can have a null value. during iTop object synchronization you can decide either

• to reset the object field value on iTop side (during synchronization) and do nothing special in iTop configuration.
• to update the field to a default value configured on collector side. use "default" configuration section for that purpose
• to keep its previous value by leaving it untouch and sending '' to iTop synchonization. you have to configure collector with a nullified section.

we propose to have same "untouch" behaviour for empty string values collected. as a matter of fact null cannot be collected for some type of collectors (like CSV). which make the "nullify" feature unusable... seems like a bug to me.

• cf documentation :

https://wiki.combodo.com/doku.php?id=extensions:itop-data-collector-base#reset_or_untouch

• cf PR that brought the feature:

#7

[Hipska]

I'm only concerned on how to sync a NULL value into a nullable DECIMAL field in iTop. I think that is still not possible, even with these additions?

Edit: This is the correct link to the documentation: https://www.itophub.io/wiki/page?id=extensions:itop-data-collector-base#reset_or_untouch

[Molkobain]

Suggested change

	if (strlen($aRow[$sHeader])==0 && $this->AttributeIsNullified($sHeader)) {
	if (strlen($aRow[$sHeader] ?? '') === 0 && $this->AttributeIsNullified($sHeader)) {

Otherwise in case a null value (as it seem it can be possible) it will trigger a warning with PHP 8.

[Molkobain]

I'm only concerned on how to sync a NULL value into a nullable DECIMAL field in iTop. I think that is still not possible, even with these additions?

Edit: This is the correct link to the documentation: https://www.itophub.io/wiki/page?id=extensions:itop-data-collector-base#reset_or_untouch

Could we add a unit test on that to check and to ensure that we keep the intended behavior?