Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't try to load module if there is none #5

Merged

Conversation

Hipska
Copy link
Collaborator

@Hipska Hipska commented Aug 19, 2020

This would generate a warning every run. Now I made it an info log message.

Also fixed a php warning of glob returning false instead of empty array in some cases.

This will fix #4, I had problems updating that branch.

@piRGoif
Copy link
Contributor

piRGoif commented Aug 19, 2020

Ok, I'm closing #4 !

@Hipska Hipska requested a review from dflaven September 15, 2020 09:43
@odain-cbd odain-cbd self-assigned this Oct 1, 2020
@Hipska Hipska requested a review from odain-cbd October 2, 2020 07:32
@odain-cbd
Copy link
Contributor

thanks for your contribution Hispka. code is better that way.

@odain-cbd odain-cbd closed this Oct 5, 2020
@Hipska
Copy link
Collaborator Author

Hipska commented Oct 5, 2020

Erm, why close it and not merge?

@odain-cbd odain-cbd reopened this Oct 5, 2020
@odain-cbd odain-cbd merged commit d010937 into Combodo:master Oct 5, 2020
@odain-cbd
Copy link
Contributor

sorry I am not so fond of github UI. i had to reopen and really merge

@Hipska Hipska deleted the feature/fix-version-loading branch October 5, 2020 12:51
@Hipska
Copy link
Collaborator Author

Hipska commented Oct 6, 2020

Hi, could you please also add the hacktoberfest tag to this repo? Hacktoberfest/hacktoberfest-2020#596

@Molkobain
Copy link
Contributor

Hello @Hipska , can you argue on why we should tag the repo and how it benefits the repo? This has nothing to do with iTop right? (I didn't read the post)

@Hipska
Copy link
Collaborator Author

Hipska commented Oct 6, 2020

It gives rewards to people that contribute open source during October. But only on repo's that have the tag, this is a recent change to fight spam PR's.
The benefit might be that others will find it and may contribute as well.

@Molkobain
Copy link
Contributor

Okay thanks for the explanation, I'll check with the rest of the team right today.

Not sure it will bring much light on iTop but it won't do any harm either! And above all, if it can be a little token of our appreciation for all your work on the iTop ecosystem, I'm more than ok with it 😊

@Molkobain
Copy link
Contributor

The topic was just added to this repo and iTop's. Thanks for your contributions @Hipska ! 😊

@piRGoif piRGoif added the enhancement New feature or request label May 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants