-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Don't try to load module if there is none #5
Don't try to load module if there is none #5
Conversation
Ok, I'm closing #4 ! |
thanks for your contribution Hispka. code is better that way. |
Erm, why close it and not merge? |
sorry I am not so fond of github UI. i had to reopen and really merge |
Hi, could you please also add the |
Hello @Hipska , can you argue on why we should tag the repo and how it benefits the repo? This has nothing to do with iTop right? (I didn't read the post) |
It gives rewards to people that contribute open source during October. But only on repo's that have the tag, this is a recent change to fight spam PR's. |
Okay thanks for the explanation, I'll check with the rest of the team right today. Not sure it will bring much light on iTop but it won't do any harm either! And above all, if it can be a little token of our appreciation for all your work on the iTop ecosystem, I'm more than ok with it 😊 |
The topic was just added to this repo and iTop's. Thanks for your contributions @Hipska ! 😊 |
This would generate a warning every run. Now I made it an info log message.
Also fixed a php warning of glob returning false instead of empty array in some cases.
This will fix #4, I had problems updating that branch.