-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
JsonCollector: Introduce GetOptionalHeaders() and GetCurlOptions() methods #44
Open
jbostoen
wants to merge
8
commits into
Combodo:master
Choose a base branch
from
jbostoen:feature_jsoncollector_customheaders
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
JsonCollector: Introduce GetOptionalHeaders() and GetCurlOptions() methods #44
jbostoen
wants to merge
8
commits into
Combodo:master
from
jbostoen:feature_jsoncollector_customheaders
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Molkobain
suggested changes
Jan 16, 2024
Hipska
suggested changes
Jan 17, 2024
Co-authored-by: Thomas Casteleyn <[email protected]>
Co-authored-by: Thomas Casteleyn <[email protected]>
Co-authored-by: Thomas Casteleyn <[email protected]>
Molkobain
reviewed
Jan 18, 2024
Hipska
reviewed
Jan 18, 2024
Hipska
approved these changes
Jan 18, 2024
I come after all other feedbacks. everything is ok to me. great job and idea! NB: |
odain-cbd
approved these changes
Jan 22, 2024
Molkobain
approved these changes
Feb 6, 2024
Technical review:
|
Note: Maybe we should use \CallItopService::CallItopViaHttp() instead and adjust the factorisation |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR intends to make it easier to extend the JsonCollector.
Use case: A third-party API which requires Basic Authorization with each POST request.
Basic Authorization can basically be performed in these ways:
CURLOPT_USERPWD
.Without the PR:
WIth the PR:
By default, no HTTP headers are set.
By default, cURL options = cURL options as defined in the "conf" XML (as before); and cURL options as defined in the "collectors" XML (these are superseding).
Note: I used the correct spelling of "optional". In the source code, it's consistently written incorrectly with "optionnal". I was considering updating it, but that might cause issues if people already extended classes and if those methods were overridden.