Export the registration manager and disable relevant tests #12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cnx-jd
reviewed
Sep 27, 2022
| @@ -39,7 +39,7 @@ set(SOURCE_FILES main.cpp | |||
| misc/array_range_test.cpp | |||
| misc/string_view_test.cpp | |||
| misc/enum_flags_test.cpp | |||
| misc/library_test.cpp | |||
| # misc/library_test.cpp After exporting the registration manager, the library test does not make sense any more. | |||
There was a problem hiding this comment.
I don't know why you think it doesn't make any sense anymore. This plugin library loading functionality that is heavily used by OMX and RTX
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In order to split RTTR registration libraries, we have to export the registration manager so multiple dlls will have a single registration table.
This PR exports it and disables the library_test UTs as they are no longer relevant.