fix: Require cabinetry v0.5.1+ #345
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* cabinetry v0.5.0+ requires pyhf v0.7.0 which requires jsonschema>=4.15.0. Use mamba for the install to consolidate as many of the library requirements into a single virtual environment.
…tall * As all files that exist in a Docker RUN layer at build get zipped up into the archive for that layer it is necessary to remove them in the same layer they were created in help decrease image size if they would normally be removed later.
|
(As I'm writing this before the CI has a chance to go) I built one of the images locally and looks good to go for what we need: $ docker run \
--rm \
-ti \
hub.opensciencegrid.org/coffea-casa/cc-base-centos7:latest /bin/bash
+ sed -i -e 's|LocalCluster|LocalCluster|g' /opt/dask/labextension.yaml
+ sed -i -e 's|dask.distributed|dask.distributed|g' /opt/dask/labextension.yaml
+ sed -i -e 's|Local Cluster|Local Cluster|g' /opt/dask/labextension.yaml
+ echo 'CONDOR_HOST = red-condor.unl.edu'
+ echo 'COLLECTOR_NAME = Nebraska T2'
+ echo 'UID_DOMAIN = unl.edu'
+ echo 'SCHEDD_HOST = t3.unl.edu'
+ '[' -e /home/cms-jovyan/environment.yml ']'
+ '[' -e /home/cms-jovyan/environment.yaml ']'
+ echo 'No environment.yml, conda will not install any package.'
No environment.yml, conda will not install any package.
+ '[' -e /home/cms-jovyan/requirements.txt ']'
+ echo 'No requirements.txt, pip will not install any module.'
No requirements.txt, pip will not install any module.
+ '[' '' ']'
+ '[' '' ']'
+ exec /bin/bash
(base) [cms-jovyan@6eac8db7124a ~]$ mamba list | grep "pyhf\|cabinetry\|jsonschema"
cabinetry 0.5.1 pyhd8ed1ab_0 conda-forge
jsonschema 4.15.0 pyhd8ed1ab_0 conda-forge
pyhf 0.7.0 pyhd8ed1ab_0 conda-forge
python-fastjsonschema 2.16.1 pyhd8ed1ab_0 conda-forge
(base) [cms-jovyan@6eac8db7124a ~]$ 👍 |
|
@oshadura this is ready for review now. |
|
@oshadura ping just to get this back on the notification stack. No rush here obviously. :) |
|
perfect! many thanks for your contribution! |
|
failure is unrelated, I will fix CI later in a different PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #344
cabinetryv0.5.0+requirespyhfv0.7.xwhich requiresjsonschema>=4.15.0. Usemambafor the install ofcabinetryto consolidate as many of the library requirements into a single virtual environment.mambaclean actions in the same layer as mamba install to help decrease image size.mamba installis used during the image build. If not, then instances ofmamba cleanare left in place to avoid noisy diffs that would be cosmetic to the image size.