refactor: covert isSearchSupported from property to method in eventRe…

…pository
CodyTseng · Mar 23, 2024 · ec063a7 · ec063a7
1 parent 3403dc7
commit ec063a7
Show file tree

Hide file tree

Showing 5 changed files with 14 additions and 4 deletions.
diff --git a/packages/common/src/interfaces/event-repository.interface.ts b/packages/common/src/interfaces/event-repository.interface.ts
@@ -19,9 +19,9 @@ export interface EventRepositoryUpsertResult {
  */
 export abstract class EventRepository {
   /**
-   * This property indicates whether the search feature is supported.
+   * Whether the search feature is supported.
    */
-  readonly isSearchSupported: boolean = false;
+  abstract isSearchSupported(): boolean;
 
   /**
    * This method is called when a new event should be stored. You should handle

diff --git a/packages/core/__test__/services/event.service.spec.ts b/packages/core/__test__/services/event.service.spec.ts
@@ -21,7 +21,7 @@ describe('eventService', () => {
 
   beforeEach(() => {
     eventRepository = {
-      isSearchSupported: false,
+      isSearchSupported: jest.fn().mockReturnValue(false),
       upsert: jest.fn(),
       find: jest.fn(),
       findOne: jest.fn(),

diff --git a/packages/core/src/services/event.service.ts b/packages/core/src/services/event.service.ts
@@ -123,7 +123,7 @@ export class EventService {
     const callback = async (): Promise<Event[]> => {
       if (
         filter.search !== undefined &&
-        !this.eventRepository.isSearchSupported
+        !this.eventRepository.isSearchSupported()
       ) {
         return [];
       }

diff --git a/packages/event-repository-sqlite/__test__/event-repository-sqlite.spec.ts b/packages/event-repository-sqlite/__test__/event-repository-sqlite.spec.ts
@@ -16,6 +16,12 @@ describe('EventRepositorySqlite', () => {
     eventRepository.close();
   });
 
+  describe('isSearchSupported', () => {
+    it('should return false', () => {
+      expect(eventRepository.isSearchSupported()).toBe(false);
+    });
+  });
+
   describe('upsert', () => {
     it('should insert a new event', async () => {
       const eventA = createEvent({

diff --git a/packages/event-repository-sqlite/src/event-repository-sqlite.ts b/packages/event-repository-sqlite/src/event-repository-sqlite.ts
@@ -20,6 +20,10 @@ export class EventRepositorySqlite extends EventRepository {
     this.migrate();
   }
 
+  isSearchSupported(): boolean {
+    return false;
+  }
+
   close(): void {
     this.db.close();
   }