Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: change exception message in commands #46

Closed

Conversation

drjova
Copy link

@drjova drjova commented Dec 19, 2023

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (830316e) 95.65% compared to head (36eb5eb) 95.65%.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@           Coverage Diff           @@
##           master      #46   +/-   ##
=======================================
  Coverage   95.65%   95.65%           
=======================================
  Files          12       12           
  Lines         576      576           
  Branches       80       80           
=======================================
  Hits          551      551           
  Misses         21       21           
  Partials        4        4           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@qcoumes
Copy link
Member

qcoumes commented Jan 11, 2024

Hello, sorry for the late reply.

I would prefer something like the parsing of the OpenSearch's response to provide a more precise exception for the most common errors instead of one general exception for all errors.

@qcoumes
Copy link
Member

qcoumes commented Mar 18, 2024

It has been chosen to instead display the raw error from OpenSearch since there is no documented list of existing error codes.

#49

@qcoumes qcoumes closed this Mar 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Better handling of exception at Index creation
3 participants