Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add JoinField and update indexation command to select on which … #38

Open
wants to merge 9 commits into
base: master
Choose a base branch
from

Conversation

Virgin75
Copy link

@Virgin75 Virgin75 commented Apr 4, 2023

…models to start the indexation

  • Add JoinField in fields.py to allow easy creation of parent/child join type field.
  • Edit indexation management command to allow start of the indexation on specific models only (with --objects).
    Usage, e.g: python3 manage.py opensearch document index --objects stay document will only start the indexation for the registered models using the Stay and Document models (defined in Django inner class).

@codecov-commenter
Copy link

codecov-commenter commented Apr 4, 2023

Codecov Report

Attention: Patch coverage is 43.75000% with 36 lines in your changes are missing coverage. Please review.

Project coverage is 90.00%. Comparing base (4d4f437) to head (8980d89).
Report is 5 commits behind head on master.

❗ Current head 8980d89 differs from pull request most recent head 4f04a28. Consider uploading reports for the commit 4f04a28 to get more accurate results

Files Patch % Lines
...o_opensearch_dsl/management/commands/opensearch.py 42.10% 30 Missing and 3 partials ⚠️
django_opensearch_dsl/registries.py 50.00% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master      #38      +/-   ##
==========================================
- Coverage   95.93%   90.00%   -5.94%     
==========================================
  Files          12       12              
  Lines         615      620       +5     
  Branches       86       93       +7     
==========================================
- Hits          590      558      -32     
- Misses         20       55      +35     
- Partials        5        7       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Virgin75 Virgin75 force-pushed the feat/join_field_and_update_index_command branch 2 times, most recently from 8980d89 to d0833e6 Compare April 5, 2023 13:00
@qcoumes qcoumes force-pushed the feat/join_field_and_update_index_command branch 3 times, most recently from d0ee947 to 351c4b4 Compare March 21, 2024 10:40
@qcoumes qcoumes mentioned this pull request Mar 22, 2024
7 tasks
@qcoumes qcoumes force-pushed the feat/join_field_and_update_index_command branch from 351c4b4 to 4f04a28 Compare March 25, 2024 13:29
@qcoumes qcoumes force-pushed the feat/join_field_and_update_index_command branch from 158348a to 9d1383f Compare October 1, 2024 04:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants