Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes for redhat yaml extension #541

Merged
merged 2 commits into from
Dec 12, 2024
Merged

Fixes for redhat yaml extension #541

merged 2 commits into from
Dec 12, 2024

Conversation

CGNonofr
Copy link
Contributor

Loïc Mangeonjean added 2 commits December 11, 2024 17:03
fix: allow extension-file and data urls in extension host
8c8b084
fix: make the extension path not end with a /
7e44d32 
because some extensions like redhat yaml just concat it with a path starting with a `/`
@CGNonofr CGNonofr requested a review from kaisalmen December 11, 2024 16:04
kaisalmen
kaisalmen approved these changes Dec 12, 2024
View reviewed changes
Copy link
Collaborator

@kaisalmen kaisalmen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you. LGTM 🎉

@CGNonofr CGNonofr merged commit 2c59c3b into main Dec 12, 2024
2 checks passed
@CGNonofr CGNonofr deleted the fix-yaml-extension branch December 12, 2024 09:13
@CGNonofr
Copy link
Contributor Author

Thank you. LGTM 🎉

Btw, I've noticed that the build process is not deterministic... the generated common packages can change between builds. In addition to the missing common package dependencies on the main package, I hope that it won't break anything. I've started working on a refactor of the build process, but I didn't have the time to move forward on it for a few weeks now... I'll maybe find some time in the next week

@github-actions GitHub Actions
Copy link

🎉 This PR is included in version 11.1.2 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

@kaisalmen
Copy link
Collaborator

but I didn't have the time to move forward on it for a few weeks now... I'll maybe find some time in the next week

@CGNonofr all good. I need to catch-up myself. I haven't noticed anything strange so far.

Maybe you also have an idea to enforce dependencies already on this level by an artificial package every other one relies on (see TypeFox/monaco-languageclient#789). I will test some ideas on mlc level hopefully tomorrow.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kaisalmen kaisalmen kaisalmen approved these changes

Assignees
No one assigned
Labels
released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@CGNonofr @kaisalmen