Update to VSCode 1.95 #532
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 12 commits
October 31, 2024 12:21
instead of putting all common stuff in the main package, leading to it depending on xterm
|
@kaisalmen build fixed :) |
kaisalmen
approved these changes
Nov 8, 2024
It's a big change indeed that was pretty challenging to implement, the rollup code is now quite complex 🤔 I'll try to rework it to simplify it some day, it probably still contain a lot of legacy stuff |
|
🎉 This PR is included in version 11.0.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When upgrading, the #520 issue came back
So to fix it, I've changed the build behavior: instead of putting everything that is used by at least 2 service-override in the main package, I create a
commonpackage for it. To not create too many new packages, only common packages containing at least 10 modules are kept, others still rely on the previous behavior