Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to VSCode 1.94 #504

Merged
merged 7 commits into from
Oct 7, 2024
Merged

Update to VSCode 1.94 #504

merged 7 commits into from
Oct 7, 2024

Conversation

CGNonofr
Copy link
Contributor

@CGNonofr CGNonofr commented Oct 7, 2024

No description provided.

@CGNonofr CGNonofr requested a review from kaisalmen October 7, 2024 14:04
@CGNonofr CGNonofr self-assigned this Oct 7, 2024
@CGNonofr CGNonofr force-pushed the update-vscode-1.94 branch from 4ddc418 to 361ac1e Compare October 7, 2024 14:23
@CGNonofr CGNonofr force-pushed the update-vscode-1.94 branch from 361ac1e to 3c8da49 Compare October 7, 2024 14:26
@CGNonofr CGNonofr force-pushed the update-vscode-1.94 branch from 3c8da49 to b3ac17a Compare October 7, 2024 15:44
@CGNonofr
Copy link
Contributor Author

CGNonofr commented Oct 7, 2024

@kaisalmen it's finally working and ready for review!

@brianjenkins94
Copy link

Any big treeshake-ability wins from 1.94 switching to ESM?

@CGNonofr
Copy link
Contributor Author

CGNonofr commented Oct 7, 2024

Any big treeshake-ability wins from 1.94 switching to ESM?

Not really, everything was already mostly ESM

Copy link
Collaborator

@kaisalmen kaisalmen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I will test this with the monaco-languageclient stack.

@CGNonofr CGNonofr merged commit 73c8db9 into main Oct 7, 2024
2 checks passed
@CGNonofr CGNonofr deleted the update-vscode-1.94 branch October 7, 2024 19:21
Copy link

github-actions bot commented Oct 7, 2024

🎉 This PR is included in version 10.0.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants