Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix regex validation #463

Merged
merged 2 commits into from
Jul 12, 2024
Merged

Fix regex validation #463

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a7d978b
fix: replace unsupported by empty implementations
Jul 12, 2024
537c0fe
fix: enable tryCatchDeoptimization
Jul 12, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion rollup/rollup.config.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -407,7 +407,8 @@ export default (args: Record<string, string>): rollup.RollupOptions[] => {
treeshake: {
annotations: true,
preset: 'smallest',
moduleSideEffects: true
moduleSideEffects: true,
tryCatchDeoptimization: true
},
external,
output: [{
Expand Down Expand Up @@ -598,6 +599,7 @@ export default (args: Record<string, string>): rollup.RollupOptions[] => {
annotations: true,
preset: 'smallest',
propertyReadSideEffects: false,
tryCatchDeoptimization: true,
moduleSideEffects (id) {
return id.startsWith(DIST_DIR) || id.endsWith('.css')
}
Expand Down
6 changes: 3 additions & 3 deletions src/missing-services.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2719,13 +2719,13 @@ registerSingleton(IShareService, class ShareService implements IShareService {
registerSingleton(IUserDataProfileImportExportService, class UserDataProfileImportExportService implements IUserDataProfileImportExportService {
_serviceBrand: undefined
createProfileFromTemplate = async () => undefined
resolveProfileTemplate = unsupported
resolveProfileTemplate = async () => null
exportProfile2 = unsupported
createFromProfile = unsupported
createProfile = unsupported
editProfile = unsupported
registerProfileContentHandler = unsupported
unregisterProfileContentHandler = unsupported
registerProfileContentHandler = () => Disposable.None
unregisterProfileContentHandler = () => {}
exportProfile = unsupported
importProfile = unsupported
showProfileContents = unsupported
Expand Down