-
Notifications
You must be signed in to change notification settings - Fork 38
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Full containerized build #457
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
great idea, thank you! |
kaisalmen
force-pushed
the
containerized-build
branch
from
July 2, 2024 12:15
4b42b39
to
387093a
Compare
kaisalmen
commented
Jul 2, 2024
@CGNonofr WDYT? |
CGNonofr
reviewed
Jul 3, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work! just a little comment regarding docker image version
kaisalmen
force-pushed
the
containerized-build
branch
from
July 8, 2024 13:34
387093a
to
b28e508
Compare
CGNonofr
approved these changes
Jul 8, 2024
🎉 This PR is included in version 7.0.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allow to build project in container and to use vscode devcontainer for development.
@CGNonofr this is to overcome build problems on Windows. The Dockerfile also basically describes what needs to be installed on a Linux system to allow building the project.
This should circumvent #420 and I will not document #420 (comment) in the Troubleshooting because it is Windows tooling /node-gyp issue independent of this project,
TODO: