Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Full containerized build #457

Merged
merged 2 commits into from
Jul 8, 2024
Merged

Full containerized build #457

merged 2 commits into from
Jul 8, 2024

Conversation

kaisalmen
Copy link
Collaborator

@kaisalmen kaisalmen commented Jul 2, 2024

Allow to build project in container and to use vscode devcontainer for development.

@CGNonofr this is to overcome build problems on Windows. The Dockerfile also basically describes what needs to be installed on a Linux system to allow building the project.

This should circumvent #420 and I will not document #420 (comment) in the Troubleshooting because it is Windows tooling /node-gyp issue independent of this project,

TODO:

  • Install, build and demo build must work in container
  • Update REAMDE / Troubleshooting section

@kaisalmen kaisalmen changed the title WIP: Full containerized buil WIP: Full containerized build Jul 2, 2024
@CGNonofr
Copy link
Contributor

CGNonofr commented Jul 2, 2024

great idea, thank you!

@kaisalmen kaisalmen force-pushed the containerized-build branch from 4b42b39 to 387093a Compare July 2, 2024 12:15
@kaisalmen kaisalmen changed the title WIP: Full containerized build Full containerized build Jul 2, 2024
@kaisalmen kaisalmen marked this pull request as ready for review July 2, 2024 12:15
README.md Outdated Show resolved Hide resolved
@kaisalmen
Copy link
Collaborator Author

@CGNonofr WDYT?

Copy link
Contributor

@CGNonofr CGNonofr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work! just a little comment regarding docker image version

.devcontainer/Dockerfile Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
@kaisalmen kaisalmen force-pushed the containerized-build branch from 387093a to b28e508 Compare July 8, 2024 13:34
@CGNonofr CGNonofr self-requested a review July 8, 2024 13:36
@kaisalmen kaisalmen merged commit 780453a into main Jul 8, 2024
2 checks passed
@kaisalmen kaisalmen deleted the containerized-build branch July 8, 2024 15:50
Copy link

github-actions bot commented Jul 8, 2024

🎉 This PR is included in version 7.0.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants