Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve registered file system #434

Merged
merged 7 commits into from
May 23, 2024
Merged

Conversation

CGNonofr
Copy link
Contributor

What it improves:

  • it use a tree to store the filesystem instead of a flat file list (for better perfs, similiar to InMemoryFileSystemProvider)
  • it implement the file stream api
  • it doesn't rely anymore on the file content to get the file size => removing the need to get the file twice (one from the stat to get the size then another one to get the content) => removing the need to memoize the file content => stop keeping all the file content in memory, reducing memory footprint

@CGNonofr CGNonofr requested review from CompuIves and kaisalmen May 23, 2024 10:36
Copy link
Collaborator

@kaisalmen kaisalmen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sounds good. As usual I will test the new release with the monaco-languageclient stack. LGTM.

@CGNonofr CGNonofr merged commit 41cbe75 into main May 23, 2024
2 checks passed
@CGNonofr CGNonofr deleted the improve-registered-file-system branch May 23, 2024 12:13
Copy link

🎉 This PR is included in version 5.2.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants