fix: add missing accessibleView service #429
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CompuIves
force-pushed
the
fix/missing-service
branch
from
cf49511 to
65f352b
Compare
CGNonofr
approved these changes
May 13, 2024
|
Once the checks succeed, would it be possible to cut a new release? I think this is the main thing holding us back from upgrading to the new VSCode (for some reason, I think that sidebar views contributed by extensions don't work because this service is missing) |
Sure, I would just like to add some small fixes (PR incoming soon) |
|
🎉 This PR is included in version 5.1.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed that sometimes a new service (introduced with VSCode 1.89) is required, called the
AccessibleViewInformationService. In this PR I add this service, together with another service related to accessibility I found.Fixes: