-
Notifications
You must be signed in to change notification settings - Fork 37
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Optimize localization #417
Conversation
It allows to not have to call 'localize' ourselves
replace localization keys by indexes
b7fc924
to
35b66ee
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you. Tested locally. Have not seen anything obvious. Changing languages works nicely. I did not perform an in-depth review of the code. Will test the new release as usual.
🎉 This PR is included in version 4.5.2 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Apply the same optimization than VScode in vscode.dev, which replaces string translation keys by their indexes within the module
in the localization file:
is replaced by
and in the modules:
is replaced by
This PR:
Note that the localization keys can't be minified and neither be compressed very well (each key is different) so the final compressed size ratio should be even bigger