-
Notifications
You must be signed in to change notification settings - Fork 37
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix encoding management #413
Conversation
CGNonofr
commented
Apr 19, 2024
•
edited
Loading
edited
- Restore the usage of @vscode/iconv-lite-umd/jschardet to detect/handle different encoding (they are lazy-loaded)
- Remove some mocked file
- Attempt to move as much code as possible to the leaf packages: it allowed to remove almost 2mo from the main package
as it seems they are not used anymore from outside and will be only contained by the sync service override
to prevent putting view-specific code in the main package
ab3e4d1
to
7563299
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Local test look good and potentially smaller bundles are very welcome by end-users.
You introduced a new service and did not document it that's why I request changes.
Since it's an internal service override, I was wondering if it was worth it to document it 🤔 |
Yes, that makes sense |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@CGNonofr Are more changes upcoming or is there another reason you did not merge this, yet? |
There are some... experiments, but if it leads to anything it'll be in another MR |
🎉 This PR is included in version 4.5.0-improve-code-splitting.1 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
We can release anytime if you want! I don't have anything else in the pipe though :) |
We can combine it with other PR. No pressure from my side. I am busy with something else this week. |
🎉 This PR is included in version 4.5.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |