Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix color picker #392

Merged
merged 1 commit into from
Apr 12, 2024
Merged

Fix color picker #392

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion rollup/rollup.config.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -64,6 +64,10 @@ const PURE_FUNCTIONS = new Set([
'negate'
])

const SIDE_EFFECT_CONSTRUCTORS = new Set([
'DomListener'
])

const PURE_OR_TO_REMOVE_FUNCTIONS = new Set([
...PURE_FUNCTIONS
])
Expand Down Expand Up @@ -197,7 +201,7 @@ function transformVSCodeCode (id: string, code: string) {
},
visitNewExpression (path) {
const node = path.node
if (node.callee.type === 'Identifier') {
if (node.callee.type === 'Identifier' && !SIDE_EFFECT_CONSTRUCTORS.has(node.callee.name)) {
path.replace(addComment(node))
}
this.traverse(path)
Expand Down