Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update to VSCode 1.88 #384

Merged
merged 8 commits into from
Apr 9, 2024
Merged

Update to VSCode 1.88 #384

merged 8 commits into from
Apr 9, 2024

Conversation

CGNonofr
Copy link
Contributor

@CGNonofr CGNonofr commented Apr 8, 2024

No description provided.

@CGNonofr CGNonofr requested review from CompuIves and kaisalmen April 8, 2024 19:17
kaisalmen
kaisalmen previously approved these changes Apr 9, 2024
View reviewed changes
Copy link
Collaborator

@kaisalmen kaisalmen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested locally. Looks good. LGTM

@kaisalmen
Copy link
Collaborator

kaisalmen commented Apr 9, 2024 •
edited
Loading

@CGNonofr oh there is an error in the demo build. The signature of TestRun changed It seems addCoverage should now be used.

@CGNonofr
Copy link
Contributor Author

CGNonofr commented Apr 9, 2024

@CGNonofr oh there is an error in the demo build. The signature of TestRun changed It seems addCoverage should now be used.

Indeed! it's fixed :)

kaisalmen
kaisalmen approved these changes Apr 9, 2024
View reviewed changes
Copy link
Collaborator

@kaisalmen kaisalmen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Re-approved.

@CGNonofr CGNonofr merged commit 11f634c into main Apr 9, 2024
2 checks passed
@CGNonofr CGNonofr deleted the vscode-1.88 branch April 9, 2024 09:17
@github-actions GitHub Actions
Copy link

github-actions bot commented Apr 9, 2024

🎉 This PR is included in version 4.0.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

@kaisalmen
Copy link
Collaborator

@CGNonofr in monaco-languageclient with the new packages and no code changes I see this problem:
image

@CGNonofr
Copy link
Contributor Author

CGNonofr commented Apr 9, 2024

@CGNonofr in monaco-languageclient with the new packages and no code changes I see this problem: image

Well spotted! fixed by the last commit of #385

@kaisalmen
Copy link
Collaborator

Well spotted!

Thanks, just approved the PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kaisalmen kaisalmen kaisalmen approved these changes

@CompuIves CompuIves Awaiting requested review from CompuIves

Assignees
No one assigned
Labels
released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@CGNonofr @kaisalmen