Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use official ext host server #380

Merged
merged 6 commits into from
Mar 29, 2024
Merged

Use official ext host server #380

merged 6 commits into from
Mar 29, 2024

Conversation

CGNonofr
Copy link
Contributor

There is no point of building the server when Microsoft already does it for us

It allows to simplifies the build process but also simplifies the usage in a docker environment: you don't need node or npm, the VSCode server is a standalone

@CGNonofr CGNonofr requested review from CompuIves and kaisalmen March 27, 2024 18:26
@CGNonofr CGNonofr force-pushed the use-official-ext-host-server branch from 0124855 to d4f1bf7 Compare March 28, 2024 10:26
@CGNonofr CGNonofr force-pushed the use-official-ext-host-server branch from d4f1bf7 to a73e2d4 Compare March 28, 2024 10:35
@CGNonofr CGNonofr force-pushed the use-official-ext-host-server branch from a73e2d4 to 4fef72c Compare March 28, 2024 10:53
@CompuIves
Copy link
Collaborator

Oh, this will simplify the build process for us as well!

@CGNonofr
Copy link
Contributor Author

Oh, this will simplify the build process for us as well!

Can you elaborate?

Copy link
Collaborator

@CompuIves CompuIves left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR speaks to how far you've come with reintegrating VSCode in a modular way. That it can interface with an official VSCode server is really cool. Changes look good to me!

@CompuIves
Copy link
Collaborator

Can you elaborate?

I'm working on VSCode Server support in CodeSandbox, and we have a build step where we build vscode server and tar it, so the server can download it. We need to build VSCode server with an old version of Node, though, because our current environment has a glibc version that's too high. Also, we need to ship standalone Node to our VMs. So this would remove both steps (building in Docker, and shipping standalone Node ourselves).

@CGNonofr CGNonofr merged commit 7b84fb7 into main Mar 29, 2024
2 checks passed
@CGNonofr CGNonofr deleted the use-official-ext-host-server branch March 29, 2024 11:06
Copy link

🎉 This PR is included in version 3.2.3 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

@kaisalmen
Copy link
Collaborator

@CGNonofr nice work. Was mostly AFK over extended easter weekend.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants