Full workbench mode #349
Full workbench mode #349
Conversation
CGNonofr
force-pushed
the
full-workbench-mode
branch
from
289da6f to
c0632d6
Compare
CGNonofr
force-pushed
the
full-workbench-mode
branch
3 times, most recently
from
d5ab6a0 to
6e1006d
Compare
|
@CGNonofr wow, I just build everything locally and checked out the demo. Looks really great. |
CGNonofr
force-pushed
the
full-workbench-mode
branch
2 times, most recently
from
c33530b to
5c5a858
Compare
|
@kaisalmen rebased on main after the other MR merge |
|
@kaisalmen or @CompuIves will you have the time to have a look at it anytime soon? |
|
@CGNonofr I will check this again today |
|
@CGNonofr The latest changes are not in |
which is already there by default
CGNonofr
force-pushed
the
full-workbench-mode
branch
from
c610a99 to
9f43733
Compare
CGNonofr
force-pushed
the
full-workbench-mode
branch
from
9f43733 to
a133ca1
Compare
|
branch rebased and next.5 in preparation btw there is not much changes with the next.4 (fc1ed50) |
There was a problem hiding this comment.
I did not perform a thorough code review, but I really like what you did. I checked the demo and tested packages with monaco-languageclient PR #600. Even if there is an "observation" it does not block this PR. LGTM. 🎉
|
🎉 This PR is included in version 2.2.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
|
Apologies for the late reply. I'll test this tomorrow as well! |
The built version of the demo seems to be not working yet