-
Notifications
You must be signed in to change notification settings - Fork 37
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Chat + notebook + welcome service overrides #294
Conversation
bc0dfc2
to
43da917
Compare
Hahaha I was meaning to contribute these extension points! Happy to see that you've already been working on this. |
43da917
to
cc57adc
Compare
cc57adc
to
c515618
Compare
Feel free to review it though (: |
b1e0456
to
ea3b8ad
Compare
ea3b8ad
to
caff81a
Compare
Any change any of you have the time to have a look at it any time soon @kaisalmen @CompuIves ? |
@CGNonofr just build it locally and want to start looking at it in a bit |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Demo looks good. Panel alignment and moving/dragging views around works fine. Is it possible to test the new service overrides?
That's not easy!
I've just realized that some assets are missing the the welcome page, working ion it |
@kaisalmen I've just added 4 new commits |
@CGNonofr no more missing image at FYI; when you click on the "Get Started with VS Code for the Web" you see the following error in the console: Do you want/can fix that? Or is it for later? |
I don't know why those errors appear but I'm able to reproduce them on vscode.dev so I guess we won't be able to make them disapear btw, 2 new commits for small fixes |
You need to update the |
package-lock updated! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
based on #290
fix #292