Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chat + notebook + welcome service overrides #294

Merged
merged 26 commits into from
Jan 9, 2024

Conversation

CGNonofr
Copy link
Contributor

@CGNonofr CGNonofr commented Dec 8, 2023

based on #290

fix #292

@CGNonofr CGNonofr requested a review from kaisalmen December 8, 2023 18:00
@CGNonofr CGNonofr changed the title Chat notebook service override Chat + notebook service override Dec 8, 2023
@CGNonofr CGNonofr force-pushed the chat-notebook-service-override branch from bc0dfc2 to 43da917 Compare December 8, 2023 18:36
@CompuIves
Copy link
Collaborator

CompuIves commented Dec 9, 2023

Hahaha I was meaning to contribute these extension points! Happy to see that you've already been working on this.

@CGNonofr CGNonofr force-pushed the chat-notebook-service-override branch from 43da917 to cc57adc Compare December 11, 2023 23:48
@CGNonofr CGNonofr changed the title Chat + notebook service override Chat + notebook + welcome service override Dec 11, 2023
@CGNonofr CGNonofr changed the title Chat + notebook + welcome service override Chat + notebook + welcome service overrides Dec 11, 2023
@CGNonofr CGNonofr force-pushed the chat-notebook-service-override branch from cc57adc to c515618 Compare January 3, 2024 16:33
@CGNonofr CGNonofr requested a review from CompuIves January 3, 2024 16:36
@CGNonofr CGNonofr marked this pull request as ready for review January 3, 2024 16:36
@CGNonofr
Copy link
Contributor Author

CGNonofr commented Jan 4, 2024

Hahaha I was meaning to contribute these extension points! Happy to see that you've already been working on this.

Feel free to review it though (:

@CGNonofr CGNonofr force-pushed the chat-notebook-service-override branch 2 times, most recently from b1e0456 to ea3b8ad Compare January 4, 2024 15:16
@CGNonofr CGNonofr force-pushed the chat-notebook-service-override branch from ea3b8ad to caff81a Compare January 4, 2024 15:24
@CGNonofr
Copy link
Contributor Author

CGNonofr commented Jan 8, 2024

Any change any of you have the time to have a look at it any time soon @kaisalmen @CompuIves ?

@kaisalmen
Copy link
Collaborator

@CGNonofr just build it locally and want to start looking at it in a bit

kaisalmen
kaisalmen previously approved these changes Jan 8, 2024
Copy link
Collaborator

@kaisalmen kaisalmen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Demo looks good. Panel alignment and moving/dragging views around works fine. Is it possible to test the new service overrides?

@CGNonofr
Copy link
Contributor Author

CGNonofr commented Jan 8, 2024

Is it possible to test the new service overrides?

That's not easy!

  • for the welcome service override: remove the defaultLayout from setup.ts or run the Help: Welcome command
  • the for chat service override, it requires complex extensions to work, I wasn't even able to make it work fully
  • for the notebook service override, you can create a notebook using the new jupyter notebook command

I've just realized that some assets are missing the the welcome page, working ion it

@CGNonofr
Copy link
Contributor Author

CGNonofr commented Jan 8, 2024

@kaisalmen I've just added 4 new commits

@kaisalmen
Copy link
Collaborator

kaisalmen commented Jan 9, 2024

@CGNonofr no more missing image at Help: Welcome. 👍

FYI; when you click on the "Get Started with VS Code for the Web" you see the following error in the console:
image

Do you want/can fix that? Or is it for later?

@CGNonofr
Copy link
Contributor Author

CGNonofr commented Jan 9, 2024

@CGNonofr no more missing image at Help: Welcome. 👍

FYI; when you click on the "Get Started with VS Code for the Web" you see the following error in the console: image

Do you want/can fix that? Or is it for later?

I don't know why those errors appear but I'm able to reproduce them on vscode.dev so I guess we won't be able to make them disapear

btw, 2 new commits for small fixes

@kaisalmen
Copy link
Collaborator

kaisalmen commented Jan 9, 2024

You need to update the package-lock.json of the demo. There is one change missing. Otherwise let's go

@CGNonofr
Copy link
Contributor Author

CGNonofr commented Jan 9, 2024

package-lock updated!

Copy link
Collaborator

@kaisalmen kaisalmen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@CGNonofr CGNonofr merged commit 5886b06 into main Jan 9, 2024
1 check passed
@CGNonofr CGNonofr deleted the chat-notebook-service-override branch January 9, 2024 13:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants