Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace map by forEach to prevent treeshaking #264

Merged
merged 2 commits into from
Nov 28, 2023
Merged

Replace map by forEach to prevent treeshaking #264

merged 2 commits into from
Nov 28, 2023

Conversation

CGNonofr
Copy link
Contributor

@CGNonofr CGNonofr commented Nov 27, 2023 •
edited
Loading

fix #262

vscode PR: microsoft/vscode#199194

@CGNonofr CGNonofr requested a review from CompuIves November 27, 2023 16:54
@CGNonofr CGNonofr requested a review from kaisalmen November 28, 2023 08:59
kaisalmen
kaisalmen approved these changes Nov 28, 2023
View reviewed changes
Copy link
Collaborator

@kaisalmen kaisalmen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's go.

@CGNonofr CGNonofr merged commit 440b831 into main Nov 28, 2023
1 check passed
@CGNonofr CGNonofr deleted the fix-treeshaken-code branch November 28, 2023 12:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kaisalmen kaisalmen kaisalmen approved these changes

@CompuIves CompuIves Awaiting requested review from CompuIves

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

EditorGroupWatermark is not shown due to tree shaker
2 participants
@CGNonofr @kaisalmen