Fix diff editor options

[CGNonofr]

supposed to fix #255 but maybe I misunderstood and fix something else?

[kaisalmen]

@CGNonofr no more pre-releases?

[CGNonofr]

@CGNonofr no more pre-releases?

Are you saying I'm too lazy ? ^^

[kaisalmen]

Are you saying I'm too lazy ? ^^

Exactly 😆 No, just saw that the last one was quite a while ago. Is it easy to produce (like press a button)? Otherwise I need to come up with a local dev setup for monaco-languageclient (script with auto-switching to linked deps)

[CGNonofr]

Are you saying I'm too lazy ? ^^

Exactly 😆 No, just saw that the last one was quite a while ago. Is it easy to produce (like press a button)? Otherwise I need to come up with a local dev setup for monaco-languageclient (script with auto-switching to linked deps)

Just a command to run, I should add a manual task in the CI!

In progress :)

[kaisalmen]

In progress :)

Thank you

[CGNonofr]

In progress :)

Thank you

Done :)

[kaisalmen]

@CGNonofr just a heads up. I won't be able to fully test this tonight, because I have to test/implement the other changes as well. I will continue tomorrow.

[kaisalmen]

monaco-languageclient builds we can ship it! 🙈

Jokes aside, I need to test this, especially the side-by-side diff. We use it one level up

[CompuIves]

So this only applies to the standalone diff editor, right?

[CGNonofr]

So this only applies to the standalone diff editor, right?

Correct!

[CGNonofr]

@kaisalmen as it only includes fixes not closely related to the api (thus monaco-languageclient) and since it fixes the demo build/deploy, what about merging it (it you see no issues with the code iself OFC) and fixing any issues in a next version?

[kaisalmen]

@CGNonofr yes, go ahead. Sorry, didn't get to it today, yet. If something comes up regarding mlc (Jump from 1.83.5 to 1.83.10), I let you know / raise an issue / PR.

[kaisalmen]

Go ahead.