Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: apply custom product configuration #253

Merged
merged 1 commit into from
Nov 20, 2023

Conversation

CompuIves
Copy link
Collaborator

Currently the custom productConfiguration is not applied. VSCode applies it manually here. We should do the same, but in our way :).

@CompuIves CompuIves requested a review from CGNonofr November 20, 2023 12:44
src/services.ts Outdated Show resolved Hide resolved
@CompuIves CompuIves force-pushed the fix/product-configuration branch from e293717 to 0f1f561 Compare November 20, 2023 15:41
src/services.ts Outdated Show resolved Hide resolved
@CompuIves CompuIves force-pushed the fix/product-configuration branch from 0f1f561 to 7b2db15 Compare November 20, 2023 17:14
CGNonofr
CGNonofr previously approved these changes Nov 20, 2023
@CGNonofr
Copy link
Contributor

you have conflicts :-\

@CompuIves
Copy link
Collaborator Author

Rebased!

@CGNonofr CGNonofr self-requested a review November 20, 2023 19:54
@CGNonofr CGNonofr force-pushed the fix/product-configuration branch from 005309d to a29b3af Compare November 20, 2023 19:57
@CGNonofr CGNonofr merged commit f51e55a into CodinGame:main Nov 20, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants