Log service override #251
Log service override #251
Conversation
…a file on the MkdirpOnWriteInMemoryFileSystemProvider
when the editor part is restored, it will try to restore the test.js from the previous session and the file doesn't exist yet
…istered by default
|
Nice PR! Does this also allow us to use more exports from VSCode directly? |
Missed that comment! What do you mean? |
|
Not entirely certain, I thought something had changed in Rollup exports, but I think I was wrong. Approved it now as it looks good! |
|
The difference in the rollup build is that previously, service-overrides that were imported by |
|
What I was trying to fix is that, as soon as a file is used at 2 different places, it was included in monaco-vscode-api to not be duplicated in the 2 sub-libraries including it. The problem with that is if a service-override A was including another one B, the A service-override was considered used at 2 different places and included in monaco-vscode-api. Now, B has A as dependency and monaco-vscode-api should be lighter |
Extract it from OutputService
also a few related fixes/changes