feat: expose additional options for registering views #249
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CompuIves
force-pushed
the
feat/expose-view-registry
branch
from
ee00df1 to
87e1307
Compare
CGNonofr
reviewed
Nov 16, 2023
CompuIves
force-pushed
the
feat/expose-view-registry
branch
from
87e1307 to
43b5165
Compare
|
Updated the disposal! |
CompuIves
force-pushed
the
feat/expose-view-registry
branch
from
43b5165 to
ae130a0
Compare
CGNonofr
approved these changes
Nov 16, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm preparing us for phase 2 of the implementation of VSCode: replacing our sidebar with the one from VSCode.
To enable this, we'll need to render some of our React components inside the sidebar, sometimes as a new view item (separate view in activity bar). With this PR, I'm extending the capabilities of
registerCustomViewto allow for:Let me know if this change makes sense to you!