Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Expose almost raw VSCode api for editor panes #239

Merged
merged 6 commits into from
Nov 13, 2023
Merged

Expose almost raw VSCode api for editor panes #239

merged 6 commits into from
Nov 13, 2023

Conversation

CGNonofr
Copy link
Contributor

The current implementation only allows to implement a small subset of what VSCode allows

@CGNonofr CGNonofr marked this pull request as draft November 13, 2023 15:51
@CGNonofr CGNonofr mentioned this pull request Nov 13, 2023
Closed
@CGNonofr CGNonofr marked this pull request as ready for review November 13, 2023 17:31
@CGNonofr CGNonofr requested a review from kaisalmen November 13, 2023 17:31
@CGNonofr
Copy link
Contributor Author

@kaisalmen do you mind having a quick look at it? (: I will let that PR create a new release

kaisalmen
kaisalmen approved these changes Nov 13, 2023
View reviewed changes
Copy link
Collaborator

@kaisalmen kaisalmen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only tested it. The custom view works, nothing seems broken. Merge at your own risk.

@CGNonofr CGNonofr merged commit 7a2fe00 into main Nov 13, 2023
1 check passed
@CGNonofr CGNonofr deleted the view-editor-expose-api branch November 13, 2023 22:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kaisalmen kaisalmen kaisalmen approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@CGNonofr @kaisalmen