Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Localization #215

Merged
merged 28 commits into from
Oct 20, 2023
Merged

Localization #215

merged 28 commits into from
Oct 20, 2023

Conversation

CGNonofr
Copy link
Contributor

Add a way to localize everything in supported languages, including vscode itself, but also extensions

Unfortunately, the code that localize extension's package.json is mixed up with the code that scan the extensions in the disk, so I need to extract/duplicate it

also fix #212

also fix a bug that can make it so some extensions are ignored, might be the cause of #199 (comment)

published as 1.83.3-next.0

new packages for language packs are @codingame/monaco-vscode-language-pack-*

Loïc Mangeonjean added 24 commits October 19, 2023 12:04
to be able to translate them using vscode-loc. In VSCode this is handled by the build process
when we're already registering another one
@CGNonofr CGNonofr requested a review from kaisalmen October 19, 2023 17:04
@kaisalmen
Copy link
Collaborator

@CGNonofr superb. This works nicely locally. I don't see the build issue we see in the pipeline. The package-lock.json has local changes after npm i, though. Will test this with monaco-languageclient where I will remove the getLocale override.

Copy link
Collaborator

@kaisalmen kaisalmen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good in monaco-languageclient. I added l10n support for one example already. LGTM 🎉

@CGNonofr
Copy link
Contributor Author

@CGNonofr superb. This works nicely locally. I don't see the build issue we see in the pipeline. The package-lock.json has local changes after npm i, though. Will test this with monaco-languageclient where I will remove the getLocale override.

I feel dumb, here's the error: 6add271 (:

Looking good in monaco-languageclient. I added l10n support for one example already. LGTM 🎉

Awesome!

@CGNonofr CGNonofr merged commit 275778b into main Oct 20, 2023
1 check passed
@CGNonofr CGNonofr deleted the l10n branch October 20, 2023 09:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

WebView background is white when system is in dark mode
2 participants