-
Notifications
You must be signed in to change notification settings - Fork 37
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixes and improvements #200
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@CGNonofr changes looks good, but I see one problem with @codingame/monaco-editor-treemended
. If I import it as such:
"monaco-editor": "npm:@codingame/monaco-editor-treemended@>=1.82.4-next.1 <1.83.0"
then it will conflict/be incompatible with the regular monaco-editor
version (e.g. 0.43.0
) people have in their dependency tree.
Any idea how to solve this? Is it possible map the imported version to another one like we basically do it with the name?
What about using the npm |
Didn't know this one. Question is if this introduces more problem then it solves regarding treemending and yarn, pnpm, etc |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. My question regarding version conflicts does not block the approval.
That solution is not perfect either, but it's an alternative to the treemending. It's probably easier for pnpm |
implements #190
fixes #198
fixes #199
workaround for #113
released as 1.82.4-next.1