Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes and improvements #200

Merged
merged 7 commits into from
Oct 7, 2023
Merged

Fixes and improvements #200

merged 7 commits into from
Oct 7, 2023

Conversation

CGNonofr
Copy link
Contributor

@CGNonofr CGNonofr commented Oct 5, 2023

implements #190
fixes #198
fixes #199
workaround for #113

released as 1.82.4-next.1

@CGNonofr CGNonofr requested a review from kaisalmen October 5, 2023 17:46
@CGNonofr CGNonofr changed the title Fix and improvements Fixes and improvements Oct 5, 2023
Copy link
Collaborator

@kaisalmen kaisalmen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@CGNonofr changes looks good, but I see one problem with @codingame/monaco-editor-treemended. If I import it as such:

"monaco-editor": "npm:@codingame/monaco-editor-treemended@>=1.82.4-next.1 <1.83.0"

then it will conflict/be incompatible with the regular monaco-editor version (e.g. 0.43.0) people have in their dependency tree.
Any idea how to solve this? Is it possible map the imported version to another one like we basically do it with the name?

@CGNonofr
Copy link
Contributor Author

CGNonofr commented Oct 7, 2023

@CGNonofr changes looks good, but I see one problem with @codingame/monaco-editor-treemended. If I import it as such:

"monaco-editor": "npm:@codingame/monaco-editor-treemended@>=1.82.4-next.1 <1.83.0"

then it will conflict/be incompatible with the regular monaco-editor version (e.g. 0.43.0) people have in their dependency tree. Any idea how to solve this? Is it possible map the imported version to another one like we basically do it with the name?

What about using the npm overrides feature?

@kaisalmen
Copy link
Collaborator

What about using the npm overrides feature?

Didn't know this one. Question is if this introduces more problem then it solves regarding treemending and yarn, pnpm, etc

Copy link
Collaborator

@kaisalmen kaisalmen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. My question regarding version conflicts does not block the approval.

@CGNonofr
Copy link
Contributor Author

CGNonofr commented Oct 7, 2023

What about using the npm overrides feature?

Didn't know this one. Question is if this introduces more problem then it solves regarding treemending and yarn, pnpm, etc

That solution is not perfect either, but it's an alternative to the treemending. It's probably easier for pnpm

@CGNonofr CGNonofr merged commit 52c94ba into main Oct 7, 2023
1 check passed
@CGNonofr CGNonofr deleted the fix-and-improvements branch October 7, 2023 11:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Regression in 1.82 command palette is broken Cannot use spaces in filename
2 participants