Demo: Console log suddenly full of errors

[kaisalmen]

Latest main. I built it on my Ubuntu WSL as usual. And I just checked the deployed version same there. Are you aware of this already?

[CGNonofr]

I wasn't! will check

[CGNonofr]

Are you able to reproduce locally? I'm not

[kaisalmen]

Yes the screenshot is from my local env, but I see the same errors with the deployed version

[CGNonofr]

Are you able to reproduce in the demo here?

[kaisalmen]

Are you able to reproduce in the demo here?

I don't understand that question ⬇️ I did a hard-reload/kill-cache

[CGNonofr]

locally in the demo here I meant :)

[kaisalmen]

The same

[kaisalmen]

I build the main here (a726df1). The PR commit of #258. Not the one from #252 and this change won't alter the result, I think.

[CompuIves]

I just noticed this too with an upgrade. For some reason disabling the snippet service made it work for me here, I can also help debug this end of day.

[CompuIves]

I've a theory, for me some issues were resolved yesterday after including https://github.com/CodinGame/monaco-vscode-api/blob/main/demo/vite.config.ts#L51-L64. I wonder if there's duplicate code.

[CGNonofr]

There is a limit while trying to inject dependencies to prevent infinite loop which is limited arbitrary to 1000. Changing it to 2000 fixes the issue so it looks like a race condition here

[CompuIves]

🤯

[CGNonofr]

Ok I'm able to reproduce locally, I wasn't up to date with the remote main. me = dumb

[CGNonofr]

I've created a PR on the VSCode side: microsoft/vscode#199037

and the PR here: #260

[CompuIves]

Oh! Very interesting to see that this was on the VSCode side!

[kaisalmen]

@CGNonofr superb! Thank you.