Merge pull request #412 from CodinGame/make-parameter-optional

Make parameter optional
CodinGame · Apr 18, 2024 · 2536025 · 2536025 · github-actions · Apr 18, 2024
2 parents 41894a1 + b257bf1
commit 2536025
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 4 deletions.
diff --git a/src/service-override/dialogs.ts b/src/service-override/dialogs.ts
@@ -66,10 +66,10 @@ interface DialogServiceOverrideProps {
    * Is an `HTMLFileSystemProvider` is used as only provider for the `file` scheme directly (without overlay)
    * Enable this option to enable browser file dialogs
    */
-  useHtmlFileSystemProvider: boolean
+  useHtmlFileSystemProvider?: boolean
 }
 
-export default function getServiceOverride ({ useHtmlFileSystemProvider }: DialogServiceOverrideProps): IEditorOverrideServices {
+export default function getServiceOverride ({ useHtmlFileSystemProvider = false }: DialogServiceOverrideProps = {}): IEditorOverrideServices {
   return {
     [IDialogService.toString()]: new SyncDescriptor(DialogService, undefined, true),
     [IFileDialogService.toString()]: useHtmlFileSystemProvider ? new SyncDescriptor(FileDialogService, undefined, true) : new SyncDescriptor(DialogServiceOverride, undefined, true)

diff --git a/src/service-override/search.ts b/src/service-override/search.ts
@@ -15,10 +15,10 @@ interface SearchServiceOverrideProps {
    * Is an `HTMLFileSystemProvider` is used as only provider for the `file` scheme directly (without overlay)
    * Enable this option to enable searching local filesystem
    */
-  useHtmlFileSystemProvider: boolean
+  useHtmlFileSystemProvider?: boolean
 }
 
-export default function getServiceOverride ({ useHtmlFileSystemProvider }: SearchServiceOverrideProps): IEditorOverrideServices {
+export default function getServiceOverride ({ useHtmlFileSystemProvider = false }: SearchServiceOverrideProps = {}): IEditorOverrideServices {
   return {
     [ISearchService.toString()]: useHtmlFileSystemProvider ? new SyncDescriptor(RemoteSearchService, [], true) : new SyncDescriptor(SearchService, [], true),
     [ISearchViewModelWorkbenchService.toString()]: new SyncDescriptor(SearchViewModelWorkbenchService, [], true),