Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix whole editor paste with locked code #125

Merged
merged 31 commits into from
Dec 12, 2024
Merged

Fix whole editor paste with locked code #125

merged 31 commits into from
Dec 12, 2024

Conversation

KaiSaba
Copy link
Collaborator

@KaiSaba KaiSaba commented Dec 5, 2024 •
edited
Loading

No description provided.

@KaiSaba KaiSaba self-assigned this Dec 5, 2024
@KaiSaba KaiSaba requested a review from CGNonofr December 5, 2024 15:29
CGNonofr
CGNonofr reviewed Dec 5, 2024
View reviewed changes
src/tools.ts Outdated Show resolved Hide resolved
CGNonofr
CGNonofr reviewed Dec 6, 2024
View reviewed changes
src/tools.ts Outdated Show resolved Hide resolved
src/tools.ts Outdated Show resolved Hide resolved
src/tools.ts Outdated Show resolved Hide resolved
@KaiSaba KaiSaba force-pushed the ksa/fix-paste-with-locked-code branch from 420fc6f to c291e16 Compare December 9, 2024 13:40
@CGNonofr CGNonofr self-requested a review December 10, 2024 10:34
@KaiSaba KaiSaba force-pushed the ksa/fix-paste-with-locked-code branch from ab9316f to 0c5ae90 Compare December 11, 2024 10:30
@KaiSaba
Copy link
Collaborator Author

KaiSaba commented Dec 11, 2024

@CGNonofr I added 3 commits to refactor and fix the remaining bugs:

  • f8cea32: refactor: refactor minusRanges function to return all ranges
  • f8c1ed4: fix: use minusRanges to get hidden areas and visible ranges in hideCodeWithoutDecoration
  • 0c5ae90: fix: fix split operation text function when uneditable range text not in text to split

@KaiSaba
Copy link
Collaborator Author

KaiSaba commented Dec 11, 2024 •
edited
Loading

@CGNonofr I added a commit to fix the line added on paste:

  • cf76aee: fix: fix locked code ranges and text split

@KaiSaba KaiSaba force-pushed the ksa/fix-paste-with-locked-code branch from 8c23db2 to cf76aee Compare December 11, 2024 15:39
@KaiSaba
Copy link
Collaborator Author

KaiSaba commented Dec 12, 2024 •
edited
Loading

@CGNonofr I add 2 commits for the last fixes and 1 commit for the tests:

@KaiSaba KaiSaba force-pushed the ksa/fix-paste-with-locked-code branch from 7335a44 to acd5928 Compare December 12, 2024 10:58
CGNonofr
CGNonofr reviewed Dec 12, 2024
View reviewed changes
src/tools.ts Outdated Show resolved Hide resolved
src/tests/utils.ts Outdated Show resolved Hide resolved
src/tools.ts Outdated Show resolved Hide resolved
src/tools/utils/editorOperationUtils.ts Show resolved Hide resolved
src/tools/utils/editorOperationUtils.ts Outdated Show resolved Hide resolved
src/tools/utils/editorOperationUtils.ts Outdated Show resolved Hide resolved
src/tools/utils/editorOperationUtils.ts Outdated Show resolved Hide resolved
src/tools/utils/editorOperationUtils.ts Outdated Show resolved Hide resolved
src/tools/utils/editorOperationUtils.ts Outdated Show resolved Hide resolved
src/tools/utils/editorOperationUtils.ts Outdated Show resolved Hide resolved
CGNonofr
CGNonofr reviewed Dec 12, 2024
View reviewed changes
tsconfig.json Outdated Show resolved Hide resolved
src/tests/utils.ts Outdated Show resolved Hide resolved
src/tests/editorOperationUtils/lockedCode.test.ts Outdated Show resolved Hide resolved
@KaiSaba KaiSaba force-pushed the ksa/fix-paste-with-locked-code branch from 0b89aee to 896f2d2 Compare December 12, 2024 15:28
@KaiSaba
Copy link
Collaborator Author

KaiSaba commented Dec 12, 2024

@CGNonofr here is the commit that refactors the minusRanges function: refactor: rename minusRange function and return values.

@KaiSaba
Copy link
Collaborator Author

KaiSaba commented Dec 12, 2024

@CGNonofr I added 2 commits:

@KaiSaba KaiSaba force-pushed the ksa/fix-paste-with-locked-code branch from f596de6 to ee6c7b9 Compare December 12, 2024 17:32
@KaiSaba
Copy link
Collaborator Author

KaiSaba commented Dec 12, 2024

@CGNonofr Here is the commit that updates the tests:

CGNonofr
CGNonofr reviewed Dec 12, 2024
View reviewed changes
src/tools/utils/editorOperationUtils.ts Outdated Show resolved Hide resolved
src/tools/utils/editorOperationUtils.ts Outdated Show resolved Hide resolved
@KaiSaba KaiSaba force-pushed the ksa/fix-paste-with-locked-code branch from ee6c7b9 to 5cfb9f1 Compare December 12, 2024 17:47
@CGNonofr CGNonofr self-requested a review December 12, 2024 17:50
@CGNonofr CGNonofr merged commit 6beb376 into main Dec 12, 2024
2 checks passed
@CGNonofr CGNonofr deleted the ksa/fix-paste-with-locked-code branch December 12, 2024 17:51
@github-actions GitHub Actions
Copy link

🎉 This PR is included in version 10.1.2 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@CGNonofr CGNonofr CGNonofr approved these changes

Assignees

@KaiSaba KaiSaba

Labels
released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@KaiSaba @CGNonofr