Merge pull request #113 from CodinGame/fix-placeholder

Fix placeholder update when model changes
CodinGame · Apr 30, 2024 · d10363c · d10363c
2 parents 910edd4 + 591fc73
commit d10363c
Showing 1 changed file with 7 additions and 4 deletions.
diff --git a/src/tools.ts b/src/tools.ts
@@ -464,6 +464,8 @@ export function addPlaceholder (
   editor: monaco.editor.ICodeEditor,
   placeholder: string
 ): monaco.IDisposable {
+  const disposableStore = new DisposableStore()
+
   const widget = new PlaceholderContentWidget(editor, placeholder)
 
   function onDidChangeModelContent (): void {
@@ -475,13 +477,14 @@ export function addPlaceholder (
   }
 
   onDidChangeModelContent()
-  const changeDisposable = editor.onDidChangeModelContent(() => onDidChangeModelContent())
-  return {
+  disposableStore.add(editor.onDidChangeModelContent(onDidChangeModelContent))
+  disposableStore.add(editor.onDidChangeModel(onDidChangeModelContent))
+  disposableStore.add({
     dispose () {
-      changeDisposable.dispose()
       editor.removeContentWidget(widget)
     }
-  }
+  })
+  return disposableStore
 }
 
 export function mapClipboard (