Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Send capabilities one by one #21

Merged
merged 1 commit into from
Oct 10, 2023
Merged

Send capabilities one by one #21

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 9 additions & 5 deletions src/capabilities.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -96,11 +96,15 @@ export function synchronizeLanguageServerCapabilities (
try {
// Synchronizing dynamic server capabilities
const sendRegistrationRequest = (registrations: readonly Registration[]) => {
clientConnection.sendRequest(RegistrationRequest.type, {
registrations: registrations.filter(r => !IGNORED_REGISTRATION_METHOD.has(r.method)).map(adaptRegistration)
}).catch(error => {
logger?.error('Unable to send registration requestion to client', { error })
})
// Send registration one by one even if it's possible to send them all at once
// Because C# LSP sends duplicated capabilities that make the client ignore the next capabilities in the list
for (const registration of registrations.filter(r => !IGNORED_REGISTRATION_METHOD.has(r.method)).map(adaptRegistration)) {
clientConnection.sendRequest(RegistrationRequest.type, {
registrations: [registration]
}).catch(error => {
logger?.error('Unable to send registration requestion to client', { error })
})
}
}
const registrationRequests = watchableServerCapabilities.getRegistrationRequests()
if (registrationRequests.length > 0) {
Expand Down