Merge branch 'jpn/fix-sdk-2' into 'master'

[FIX][SDK] fixed useless warning See merge request codingame/game-engine!321
CodinGame · Jan 5, 2024 · d8a0ebf · d8a0ebf
2 parents df23912 + 0e6fcc0
commit d8a0ebf
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 3 deletions.
diff --git a/playground/misc/misc-3-release-notes.md b/playground/misc/misc-3-release-notes.md
@@ -2,6 +2,12 @@
 
 The CodinGame SDK is regularly updated and improved. This document lets you know what changed in the latest releases.
 
+## Next version
+
+### 🐞 Bug fix
+
+- Removed "missing welcome_en.html file" warning.
+
 ## 4.4.4
 
 ### 🐞 Bug fix

diff --git a/runner/src/main/java/com/codingame/gameengine/runner/Renderer.java b/runner/src/main/java/com/codingame/gameengine/runner/Renderer.java
@@ -453,11 +453,11 @@ private void checkUniqueOpti(GameConfig gameConfig, ExportReport exportReport) {
 
     private void checkLeaguePopups(QuestionConfig questionConfig, String tag, ExportReport exportReport) {
         if (
-            !questionConfig.getWelcomeLanguageMap().containsKey(Constants.LANGUAGE_ID_ENGLISH)
-                || questionConfig.getWelcomeLanguageMap().get(Constants.LANGUAGE_ID_ENGLISH).isEmpty()
+            questionConfig.getWelcomeLanguageMap().containsKey(Constants.LANGUAGE_ID_ENGLISH)
+                && questionConfig.getWelcomeLanguageMap().get(Constants.LANGUAGE_ID_ENGLISH).isEmpty()
         ) {
             exportReport.addItem(
-                ReportItemType.WARNING, tag + "Missing welcome_"
+                ReportItemType.WARNING, tag + "Empty welcome_"
                     + Constants.LANGUAGE_CODE[Constants.LANGUAGE_ID_ENGLISH - 1] + ".html file."
             );
         } else {