Throw more specific errors

Coder-Spirit · Apr 3, 2017 · 348b6b9 · 348b6b9
1 parent f91b9bb
commit 348b6b9
Show file tree

Hide file tree

Showing 3 changed files with 5 additions and 7 deletions.
diff --git a/src/Decimal.php b/src/Decimal.php
@@ -84,7 +84,7 @@ public static function fromFloat(float $fltValue, int $scale = null, bool $remov
         if (\is_infinite($fltValue)) {
             throw new InfiniteInputError('fltValue must be a finite number');
         } elseif (\is_nan($fltValue)) {
-            throw new NaNInputError("To ensure consistency, this class doesn't handle NaN objects.");
+            throw new NaNInputError("fltValue can't be NaN");
         }
 
         $defaultScale = 16;
@@ -149,9 +149,7 @@ public static function fromString(string $strValue, int $scale = null, bool $rem
             );
 
         } else {
-            throw new \InvalidArgumentException(
-                '$strValue must be a string that represents uniquely a finite float point number.'
-            );
+            throw new NaNInputError('strValue must be a number');
         }
 
         $scale = ($scale!==null) ? $scale : $min_scale;

diff --git a/tests/Decimal/DecimalFromFloatTest.php b/tests/Decimal/DecimalFromFloatTest.php
@@ -11,7 +11,7 @@ class DecimalFromFloatTest extends TestCase
 {
     /**
      * @expectedException \DomainException
-     * @expectedExceptionMessage To ensure consistency, this class doesn't handle NaN objects.
+     * @expectedExceptionMessage fltValue can't be NaN
      */
     public function testNaN()
     {

diff --git a/tests/Decimal/DecimalFromStringTest.php b/tests/Decimal/DecimalFromStringTest.php
@@ -103,8 +103,8 @@ public function testExponentialNotation_With_ZeroExponent()
     }
 
     /**
-     * @expectedException \InvalidArgumentException
-     * @expectedExceptionMessage $strValue must be a string that represents uniquely a finite float point number.
+     * @expectedException \Litipk\BigNumbers\Errors\NaNInputError
+     * @expectedExceptionMessage strValue must be a number
      */
     public function testBadString()
     {