Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

strings moved to "lang" #50

Merged
merged 2 commits into from
Apr 17, 2014
Merged

strings moved to "lang" #50

merged 2 commits into from
Apr 17, 2014

Conversation

Remo
Copy link
Contributor

@Remo Remo commented Apr 17, 2014

As mentioned here #11, it would be great to have all strings in one place.

This pull request is incomplete, but before I spend more time on this, would you guys merge something like this? Anything I'd have to change? (I'm just trying to make sure I can update my concrete5recipes sites)

msurguy added a commit that referenced this pull request Apr 17, 2014
strings moved to "lang"
@msurguy msurguy merged commit d54fec7 into CodepadME:master Apr 17, 2014
@jumilla
Copy link

jumilla commented Apr 18, 2014

lang/en/admin.php is missing?

@Remo
Copy link
Contributor Author

Remo commented Apr 18, 2014

@jumilla yes, @msurguy was a bit too quick, I'm still working on it, only wanted to know if my approach is okay ;-) Here's the missing file #53 but I'll work on this today, more to come

@jumilla
Copy link

jumilla commented Apr 18, 2014

@Remo We are doing the work of translation into Japanese in jumilla/laravel-tricks now.
Since it was special, your work was taken in.

Our approach makes the directory directly under a views directory one translation file.
For example, it is put on lang//home.php by the localization strings of views/home/.blade.php.

Work is due to be finished to about one week.
I hope I can tackle work in cooperation.

@Remo
Copy link
Contributor Author

Remo commented Apr 18, 2014

@jumilla good to hear! I didn't create a file per view but only a file per view directory. Thought we'd have too much redundancy, but I'm open to change it if there's a good reason.

I've updated my other PR #53

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants