Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore!: Remove client-modules styleguide in favor of Gamut styleguide #182

Merged
merged 1 commit into from
May 3, 2024

Conversation

jrood
Copy link
Contributor

@jrood jrood commented Apr 25, 2024

Release Notes

The styleguide we actually use seems to be in the gamut repo.
https://github.com/Codecademy/gamut/tree/main/packages/styleguide

Removing this allows removal of many Storybook dependencies from this repo.

See Slack thread

This also includes an auto upgrade to resolve this issue. See Slack thread.

@jrood jrood changed the title Remove styleguide in favor of gamut styleguide Remove styleguide in favor of Gamut styleguide Apr 25, 2024
@jrood jrood changed the title Remove styleguide in favor of Gamut styleguide Remove client-modules styleguide in favor of Gamut styleguide Apr 25, 2024
@jrood jrood changed the title Remove client-modules styleguide in favor of Gamut styleguide remove(styleguide)!: Remove client-modules styleguide in favor of Gamut styleguide Apr 25, 2024
@jrood jrood changed the title remove(styleguide)!: Remove client-modules styleguide in favor of Gamut styleguide chore!: Remove client-modules styleguide in favor of Gamut styleguide Apr 25, 2024
@jrood jrood force-pushed the jrood.rm-styleguide branch from d81c087 to d07e1af Compare April 25, 2024 16:52
@jrood jrood added the release/skip Preserve the current version when merged label Apr 25, 2024
@jrood jrood force-pushed the jrood.rm-styleguide branch from d07e1af to a7fba51 Compare April 25, 2024 16:59
@jrood jrood marked this pull request as ready for review April 29, 2024 21:09
@jrood jrood requested a review from a team as a code owner April 29, 2024 21:09
@jrood jrood requested review from timjenkins, aresnik11 and dreamwasp and removed request for a team April 29, 2024 21:09
@jrood jrood force-pushed the jrood.rm-styleguide branch from a7fba51 to 942980d Compare May 3, 2024 16:35
@jrood jrood force-pushed the jrood.rm-styleguide branch from 942980d to a73beab Compare May 3, 2024 16:38
Copy link
Contributor

@dreamwasp dreamwasp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

wonderful

@jrood jrood added Ship It :shipit: Automerge this PR when possible and removed Ship It :shipit: Automerge this PR when possible labels May 3, 2024
@jrood jrood merged commit f9608dd into main May 3, 2024
10 checks passed
@jrood jrood deleted the jrood.rm-styleguide branch May 3, 2024 21:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release/skip Preserve the current version when merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Release fails with Error: fatal: ' 9007199254740991': not an integer
2 participants