Skip to content
This repository has been archived by the owner on Feb 9, 2024. It is now read-only.

Glasgow - Class 6 --- Rahma - Appolin - Nasir --- React - Hotel Group Project #596

Open
wants to merge 64 commits into
base: master
Choose a base branch
from

Conversation

ali-nasir-ali
Copy link

No description provided.

ali-nasir-ali and others added 30 commits June 16, 2023 11:15
…ooking_to_SearchRresults

6 -- using props to pass fake booking to search results
7- Calculate and show the number of nights
…-orders-to-Restaurant

Added orders state variable to Restaurant component
ali-nasir-ali and others added 26 commits June 20, 2023 10:43
…hen-clicked

15 -- highlight booking row when clicked
…-in-a-state

17 - Storing the search input in a state
…Submitting-the-form

18 -- Added onSubmit event handler on the form
…nctionality

19   implementing search functionality
…r-profile---step-1

20 ---  display a customer profile   step 1
…ile-step-2

21 -- Added some functionality to show profile button and customerProfile com…
23 -- Added the error message when url not working
@sonarcloud
Copy link

sonarcloud bot commented Jun 23, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

Comment on lines +26 to +34
<th scope="row">{props.booking.id}</th>
<td>{props.booking.title}</td>
<td>{props.booking.firstName}</td>
<td>{props.booking.surname}</td>
<td>{props.booking.email}</td>
<td>{props.booking.roomId}</td>
<td>{props.booking.checkInDate}</td>
<td>{props.booking.checkOutDate}</td>
<td>{props.numberOfNights}</td>
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

destructuring the object here would be nice, you dont have to type props.booking. on every line

@annacollins85 annacollins85 added the reviewed A volunteer has reviewed this PR label Jul 27, 2023
Copy link

@annacollins85 annacollins85 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed together in buddy session

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
reviewed A volunteer has reviewed this PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants