-
-
Notifications
You must be signed in to change notification settings - Fork 768
London_10-Saliha_Popal/ cyf-hotel-react #588
base: master
Are you sure you want to change the base?
Conversation
Installed npm install moment --save and used .diff() method.
src/App.js
Outdated
<Bookings /> | ||
<Footer const ContactInfo = {["123 Fake Street, London, E1 4UD", "[email protected]", "0123 456789"]} /> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is not the right syntax for passing a prop into a react component. Could you correct it?
src/Bookings.js
Outdated
@@ -12,7 +12,31 @@ const Bookings = () => { | |||
<div className="App-content"> | |||
<div className="container"> | |||
<Search search={search} /> | |||
{/* <SearchResults results={FakeBookings} /> */} | |||
{/* <SearchResults const bookings = {[ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's recommended not to push commented codes :)
src/Footer.js
Outdated
@@ -0,0 +1,16 @@ | |||
import React from "react"; | |||
|
|||
const Footer = (props) => { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Have you checked if this component is working as expected? If not could it be due to the syntax error on the top?
src/TouristInfoCards.js
Outdated
@@ -0,0 +1,43 @@ | |||
import React from "react"; | |||
|
|||
const TouristInfoCards = () => { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you think of creating some functionalities and not using just html to display cards for each city? this makes your code more efficient and nicer
src/SearchResults.js
Outdated
</tr> | ||
))} | ||
</tbody> | ||
</table> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks that you haven't installed prettier. I recommend going through this instruction and install it. Some of indentions are off :(
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I left some comments Saliha, feel free to get in touch if you need any clarification :)
Kudos, SonarCloud Quality Gate passed! |
Kudos, SonarCloud Quality Gate passed! |
No description provided.