Skip to content
This repository has been archived by the owner on Feb 9, 2024. It is now read-only.

London_10-Saliha_Popal/ cyf-hotel-react #588

Open
wants to merge 13 commits into
base: master
Choose a base branch
from

Conversation

SalihaPopal
Copy link

No description provided.

src/App.js Outdated
<Bookings />
<Footer const ContactInfo = {["123 Fake Street, London, E1 4UD", "[email protected]", "0123 456789"]} />
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is not the right syntax for passing a prop into a react component. Could you correct it?

src/Bookings.js Outdated
@@ -12,7 +12,31 @@ const Bookings = () => {
<div className="App-content">
<div className="container">
<Search search={search} />
{/* <SearchResults results={FakeBookings} /> */}
{/* <SearchResults const bookings = {[
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's recommended not to push commented codes :)

src/Footer.js Outdated
@@ -0,0 +1,16 @@
import React from "react";

const Footer = (props) => {
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Have you checked if this component is working as expected? If not could it be due to the syntax error on the top?

@@ -0,0 +1,43 @@
import React from "react";

const TouristInfoCards = () => {
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you think of creating some functionalities and not using just html to display cards for each city? this makes your code more efficient and nicer

</tr>
))}
</tbody>
</table>
Copy link

@migmow migmow Jun 24, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks that you haven't installed prettier. I recommend going through this instruction and install it. Some of indentions are off :(

Copy link

@migmow migmow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I left some comments Saliha, feel free to get in touch if you need any clarification :)

@SalihaPopal
Copy link
Author

SalihaPopal commented Jun 29, 2023 via email

@migmow migmow added the reviewed A volunteer has reviewed this PR label Jul 10, 2023
@sonarcloud
Copy link

sonarcloud bot commented Jul 18, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@sonarcloud
Copy link

sonarcloud bot commented Aug 28, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
reviewed A volunteer has reviewed this PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants