Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change scheme for fetch #1307

Merged
merged 15 commits into from
Jan 28, 2025
Merged

Change scheme for fetch #1307

merged 15 commits into from
Jan 28, 2025

Conversation

Dedekind561
Copy link
Contributor

What does this change?

  • Shifts event related explanation from the asynchrony block in data flows/sprint 3 -> capturing events data flows/sprint 2. (creating room for extra stuff in data-flows/sprint-3). I also think it flows better across both prep sections now.
  • Adds explanation on serving files locally with local web server with http:// scheme

I think the explanation on using the http scheme makes most sense in data-flows/sprint-3 which is why I did a minor re-jig to make way for the explanation in data-flows/sprint-3

Common Content?

n/a

  • Block/s

Common Theme?

  • Yes

Issue number: #1107

Org Content?

Sprint

Checklist

Who needs to know about this?

@netlify Netlify
Copy link

netlify bot commented Jan 14, 2025 •
edited
Loading

✅ Deploy Preview for cyf-sdc ready!

Name Link
🔨 Latest commit 7f53c75
🔍 Latest deploy log https://app.netlify.com/sites/cyf-sdc/deploys/6798cc3bba6242000878e1c7
😎 Deploy Preview https://deploy-preview-1307--cyf-sdc.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@netlify Netlify
Copy link

netlify bot commented Jan 14, 2025 •
edited
Loading

✅ Deploy Preview for cyf-curriculum canceled.

Name Link
🔨 Latest commit 7f53c75
🔍 Latest deploy log https://app.netlify.com/sites/cyf-curriculum/deploys/6798cc3b9618a0000768cddf

@netlify Netlify
Copy link

netlify bot commented Jan 14, 2025 •
edited
Loading

✅ Deploy Preview for cyf-launch ready!

Name Link
🔨 Latest commit 7f53c75
🔍 Latest deploy log https://app.netlify.com/sites/cyf-launch/deploys/6798cc3b6001480008c4cb8f
😎 Deploy Preview https://deploy-preview-1307--cyf-launch.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@netlify Netlify
Copy link

netlify bot commented Jan 14, 2025 •
edited
Loading

✅ Deploy Preview for cyf-programming ready!

Name Link
🔨 Latest commit 7f53c75
🔍 Latest deploy log https://app.netlify.com/sites/cyf-programming/deploys/6798cc3b88330700085d0671
😎 Deploy Preview https://deploy-preview-1307--cyf-programming.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse		 1 paths audited
Performance: 85 (🔴 down 14 from production)
Accessibility: 100 (no change from production)
Best Practices: 92 (no change from production)
SEO: 90 (no change from production)
PWA: -
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

@netlify Netlify
Copy link

netlify bot commented Jan 14, 2025 •
edited
Loading

✅ Deploy Preview for cyf-common ready!

Name Link
🔨 Latest commit 7f53c75
🔍 Latest deploy log https://app.netlify.com/sites/cyf-common/deploys/6798cc3b8fc23e0008f35e6e
😎 Deploy Preview https://deploy-preview-1307--cyf-common.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@netlify Netlify
Copy link

netlify bot commented Jan 14, 2025 •
edited
Loading

✅ Deploy Preview for cyf-tracks ready!

Name Link
🔨 Latest commit 7f53c75
🔍 Latest deploy log https://app.netlify.com/sites/cyf-tracks/deploys/6798cc3b106da300083d56fa
😎 Deploy Preview https://deploy-preview-1307--cyf-tracks.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@netlify Netlify
Copy link

netlify bot commented Jan 14, 2025 •
edited
Loading

✅ Deploy Preview for cyf-piscine ready!

Name Link
🔨 Latest commit 7f53c75
🔍 Latest deploy log https://app.netlify.com/sites/cyf-piscine/deploys/6798cc3be546d600083c2ebf
😎 Deploy Preview https://deploy-preview-1307--cyf-piscine.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse		 1 paths audited
Performance: 97 (🟢 up 39 from production)
Accessibility: 100 (no change from production)
Best Practices: 92 (no change from production)
SEO: 100 (no change from production)
PWA: -
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

@netlify Netlify
Copy link

netlify bot commented Jan 14, 2025 •
edited
Loading

✅ Deploy Preview for cyf-itd ready!

Name Link
🔨 Latest commit 7f53c75
🔍 Latest deploy log https://app.netlify.com/sites/cyf-itd/deploys/6798cc3ba0b37b0008dd7ab6
😎 Deploy Preview https://deploy-preview-1307--cyf-itd.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse		 1 paths audited
Performance: 85 (🔴 down 8 from production)
Accessibility: 100 (no change from production)
Best Practices: 92 (no change from production)
SEO: 100 (no change from production)
PWA: -
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

illicitonion
illicitonion approved these changes Jan 14, 2025
View reviewed changes
Copy link
Member

@illicitonion illicitonion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, a few suggestions :) Thanks!

common-content/en/module/js3/re-rendering/index.md Outdated Show resolved Hide resolved
common-content/en/module/js3/asynchrony/index.md Outdated Show resolved Hide resolved
common-content/en/module/js3/capturing-events/index.md Show resolved Hide resolved
common-content/en/module/js3/using-fetch/index.md Outdated Show resolved Hide resolved
common-content/en/module/js3/using-fetch/index.md Outdated Show resolved Hide resolved
common-content/en/module/js3/using-fetch/index.md Show resolved Hide resolved
illicitonion
illicitonion approved these changes Jan 28, 2025
View reviewed changes
Copy link
Member

@illicitonion illicitonion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

common-content/en/module/js3/capturing-events/index.md Outdated Show resolved Hide resolved
common-content/en/module/js3/synchronous-execution/index.md Outdated Show resolved Hide resolved
@Dedekind561 Dedekind561 merged commit ad31478 into main Jan 28, 2025
34 checks passed
@Dedekind561 Dedekind561 deleted the change-scheme-for-fetch branch January 28, 2025 12:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SallyMcGrath SallyMcGrath SallyMcGrath left review comments

@illicitonion illicitonion illicitonion approved these changes

Assignees
No one assigned
Labels
None yet
Projects
Curriculum Planning
Status: ✅ Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Dedekind561 @illicitonion @SallyMcGrath