Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

1113 Register must include location and made available to local leaders #1279

Merged
merged 9 commits into from
Jan 27, 2025

Conversation

SallyMcGrath
Copy link
Member

@SallyMcGrath SallyMcGrath commented Dec 30, 2024

What does this change?

pulls location data from course data files stored in org-cyf-theme
removes family name because it's too many fields

Common Content?

courses data files

Common Theme?

Fixes #1113

Register includes locations

Checklist

Who needs to know about this?

Copy link

netlify bot commented Dec 30, 2024

Deploy Preview for cyf-tracks ready!

Name Link
🔨 Latest commit f29a303
🔍 Latest deploy log https://app.netlify.com/sites/cyf-tracks/deploys/67979fea4f1eca00084d2d3e
😎 Deploy Preview https://deploy-preview-1279--cyf-tracks.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Dec 30, 2024

Deploy Preview for cyf-curriculum canceled.

Name Link
🔨 Latest commit f29a303
🔍 Latest deploy log https://app.netlify.com/sites/cyf-curriculum/deploys/67979feab2c5130007ba0851

Copy link

netlify bot commented Dec 30, 2024

Deploy Preview for cyf-sdc ready!

Name Link
🔨 Latest commit f29a303
🔍 Latest deploy log https://app.netlify.com/sites/cyf-sdc/deploys/67979fea421b710008f1d40b
😎 Deploy Preview https://deploy-preview-1279--cyf-sdc.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Dec 30, 2024

Deploy Preview for cyf-launch ready!

Name Link
🔨 Latest commit f29a303
🔍 Latest deploy log https://app.netlify.com/sites/cyf-launch/deploys/67979feab406130008225af0
😎 Deploy Preview https://deploy-preview-1279--cyf-launch.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Dec 30, 2024

Deploy Preview for cyf-programming ready!

Name Link
🔨 Latest commit f29a303
🔍 Latest deploy log https://app.netlify.com/sites/cyf-programming/deploys/67979fead87c100008bc92e0
😎 Deploy Preview https://deploy-preview-1279--cyf-programming.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
1 paths audited
Performance: 77 (🔴 down 23 from production)
Accessibility: 100 (no change from production)
Best Practices: 92 (no change from production)
SEO: 90 (no change from production)
PWA: -
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Dec 30, 2024

Deploy Preview for cyf-common ready!

Name Link
🔨 Latest commit f29a303
🔍 Latest deploy log https://app.netlify.com/sites/cyf-common/deploys/67979feaf9661200080629fb
😎 Deploy Preview https://deploy-preview-1279--cyf-common.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Dec 30, 2024

Deploy Preview for cyf-itd ready!

Name Link
🔨 Latest commit f29a303
🔍 Latest deploy log https://app.netlify.com/sites/cyf-itd/deploys/67979feac48a7f00089a709a
😎 Deploy Preview https://deploy-preview-1279--cyf-itd.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
1 paths audited
Performance: 91 (🔴 down 8 from production)
Accessibility: 100 (no change from production)
Best Practices: 92 (no change from production)
SEO: 100 (no change from production)
PWA: -
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Dec 30, 2024

Deploy Preview for cyf-piscine ready!

Name Link
🔨 Latest commit f29a303
🔍 Latest deploy log https://app.netlify.com/sites/cyf-piscine/deploys/67979fea0d82b100084f29c3
😎 Deploy Preview https://deploy-preview-1279--cyf-piscine.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
1 paths audited
Performance: 93 (🟢 up 8 from production)
Accessibility: 100 (no change from production)
Best Practices: 92 (no change from production)
SEO: 100 (no change from production)
PWA: -
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Member

@illicitonion illicitonion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You'll also need to update org-cyf-itp/tooling/netlify/functions/submission-created.js to get the new field (and stop getting the removed field), and insert it into the row

Copy link
Contributor

@kfklein15 kfklein15 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.
Will this automatically update on the spreadsheet you created?
And will this spreadsheet also then include all other courses (ITD, Piscine, etc)?

@SallyMcGrath
Copy link
Member Author

SallyMcGrath commented Jan 3, 2025

And will this spreadsheet also then include all other courses (ITD, Piscine, etc)?

It can do. It doesn't yet because that wasn't in scope.

But we can do that.

@kfklein15
Copy link
Contributor

I can create a new ticket to update the spreadsheet. This way we can deliver this ticket. Thank you. Happy for it to be merged.

@SallyMcGrath SallyMcGrath added this to the ITP -MAY-25 Launch milestone Jan 7, 2025
@SallyMcGrath SallyMcGrath added the blocked Blocked by something explained in comments label Jan 16, 2025
@illicitonion illicitonion force-pushed the feature/1113-register-region branch from 40252cd to f29a303 Compare January 27, 2025 15:02
Copy link
Member

@illicitonion illicitonion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I made the changes - approving because I'm happy with them, but will let @SallyMcGrath merge

Copy link
Member Author

@SallyMcGrath SallyMcGrath left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm merging but maybe we come back and tag this for a refactor. I don't think all this logic makes sense in this view

common-theme/layouts/_default/day-plan.html Show resolved Hide resolved
common-theme/layouts/_default/day-plan.html Show resolved Hide resolved
@SallyMcGrath SallyMcGrath merged commit 64bb52d into main Jan 27, 2025
34 checks passed
@SallyMcGrath SallyMcGrath deleted the feature/1113-register-region branch January 27, 2025 21:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
blocked Blocked by something explained in comments
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

Register must include location and made available to local leaders
3 participants