Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Karla Grajales | Sprint-2 - Module-Structuring-and-Testing-Data | SPRINT 2 #237

Open
wants to merge 28 commits into
base: main
Choose a base branch
from
Open

Karla Grajales | Sprint-2 - Module-Structuring-and-Testing-Data | SPRINT 2 #237

wants to merge 28 commits into from
+461 −38

Conversation

Grajales-K
Copy link

Learners, PR Template

Self checklist

  • I have committed my files one by one, on purpose, and for a reason
  • I have titled my PR with COHORT_NAME | FIRST_NAME LAST_NAME | REPO_NAME | WEEK
  • I have tested my changes
  • My changes follow the style guide
  • My changes meet the requirements of this task

Changelist

In this project, I learned how to use string methods by referring to the MDN documentation, how to set and manage variables, and how data flows within functions. I also learned how to invoke functions properly, debug issues to understand why something doesn't work, perform operations on strings, and iterate through strings based on their length.

Questions

Ask any questions you have for your reviewer.

@Grajales-K Grajales-K added 🔑 Priority Key Do this first 📅 Sprint 2 Assigned during Sprint 2 of this module Needs Review Participant to add when requesting review 📅 JS1 labels Dec 23, 2024
@cjyuan cjyuan added the Review in progress This review is currently being reviewed. This label will be replaced by "Reviewed" soon. label Dec 23, 2024
cjyuan
cjyuan reviewed Dec 23, 2024
View reviewed changes
Copy link

@cjyuan cjyuan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code is good.
Some of the explanations given in the debug and errors folders are not quite correct.

Sprint-2/debug/2.js Outdated Show resolved Hide resolved
Sprint-2/errors/0.js Outdated Show resolved Hide resolved
Sprint-2/implement/cases.js Outdated Show resolved Hide resolved
Sprint-2/implement/to-pounds.js Show resolved Hide resolved
@cjyuan cjyuan added Reviewed Volunteer to add when completing a review and removed Needs Review Participant to add when requesting review Review in progress This review is currently being reviewed. This label will be replaced by "Reviewed" soon. labels Dec 23, 2024
@Grajales-K Grajales-K added the Needs Review Participant to add when requesting review label Dec 23, 2024
@cjyuan
Copy link

cjyuan commented Dec 23, 2024

Changed code is good. I left you additional comments in the resolved conversations.

@cjyuan cjyuan removed the Needs Review Participant to add when requesting review label Dec 23, 2024
@Grajales-K Grajales-K added the Complete Participant to add when work is complete and review comments have been addressed label Dec 26, 2024
@Grajales-K Grajales-K mentioned this pull request Jan 1, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cjyuan cjyuan cjyuan left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
Complete Participant to add when work is complete and review comments have been addressed 📅 JS1 🔑 Priority Key Do this first Reviewed Volunteer to add when completing a review 📅 Sprint 2 Assigned during Sprint 2 of this module
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Grajales-K @cjyuan