Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use a default value for coursework LOs #10

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

illicitonion
Copy link
Member

Learners, PR Template

Self checklist

  • I have committed my files one by one, on purpose, and for a reason
  • I have tested my changes
  • My changes follow the style guide
  • My changes meet the requirements of this task

Changelist

Previously we were using a placeholder, instead of a value, and this means that the moment you type something the placeholder disappears, and you probably can't remember what format you were meant to use.

Previously we were using a placeholder, instead of a value, and this
means that the moment you type something the placeholder disappears, and
you probably can't remember what format you were meant to use.
@AdenJones123
Copy link

This is an example of a pull request

Copy link
Member

@SallyMcGrath SallyMcGrath left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not 100% sure about this because it means you will get dummy values being printed to the view when people aren't paying attention.

Should it be paired with a check in common theme to prevent this? What do you think? 🤔

@illicitonion
Copy link
Member Author

I'm not 100% sure about this because it means you will get dummy values being printed to the view when people aren't paying attention.

Yeah, that's definitely a risk :( I wish GitHub issues allowed us to do some validation on submitted values!

Should it be paired with a check in common theme to prevent this? What do you think? 🤔

Yeah, I like the idea of adding some checks when we consume these to make sure they're filled out as we expect. Ideally we could have a GitHub Action run between someone trying to add an issue and them being able to add it which could give them real-time feedback as they're creating the issue, but given we can't do that, anything that means a responsible person notices something's missing/wrong and can act on it is useful.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Development

Successfully merging this pull request may close these issues.

3 participants