Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

API documentation for alert catalogue #42

Merged
merged 5 commits into from
Dec 16, 2019
Merged

API documentation for alert catalogue #42

merged 5 commits into from
Dec 16, 2019

Conversation

navish
Copy link
Member

@navish navish commented Dec 16, 2019 •
edited
Loading

Ref #16

@navish navish requested a review from rijkerd December 16, 2019 12:05
rijkerd
rijkerd reviewed Dec 16, 2019
View reviewed changes
docs/api.md Outdated Show resolved Hide resolved
rijkerd
rijkerd reviewed Dec 16, 2019
View reviewed changes
docs/api.md Outdated Show resolved Hide resolved
rijkerd
rijkerd reviewed Dec 16, 2019
View reviewed changes
docs/api.md Show resolved Hide resolved
rijkerd
rijkerd reviewed Dec 16, 2019
View reviewed changes
docs/api.md Outdated Show resolved Hide resolved
rijkerd
rijkerd requested changes Dec 16, 2019
View reviewed changes
Copy link
Member

@rijkerd rijkerd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Check on the data type ie type that should be an object

@lykmapipo lykmapipo merged commit d752c62 into develop Dec 16, 2019
@lykmapipo lykmapipo deleted the feature/action-catalog branch December 16, 2019 14:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rijkerd rijkerd rijkerd approved these changes

@lykmapipo lykmapipo lykmapipo approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@navish @lykmapipo @rijkerd