[726] added error messages to recruitment dates in offer creation #1041
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #1041 +/- ##
==========================================
- Coverage 91.52% 90.89% -0.63%
==========================================
Files 119 119
Lines 2901 2922 +21
Branches 31 41 +10
==========================================
+ Hits 2655 2656 +1
- Misses 242 252 +10
- Partials 4 14 +10
Continue to review full report at Codecov.
|
magul
requested changes
Oct 13, 2018
There was a problem hiding this comment.
This part of validations should also be run on backend here: https://github.com/CodeForPoznan/volontulo/blob/master/backend/apps/volontulo/serializers.py#L175
| @@ -17,3 +17,7 @@ label { | |||
| text-align: left; | |||
| } | |||
| } | |||
|
|
|||
| .form-text{ | |||
| font-size: .875rem | |||
|
Backend issue here #1094 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Form show a message that date of recriutment can't be set after action is finished. Offer with wrong dates cannot be saved in database.