Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add json for multiple prior released packages from AFRL/Quantum groups #270

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

olsonse
Copy link

@olsonse olsonse commented Mar 26, 2021

Thanks for submitting a pull request! Below are a few things you can do to help us more quickly review your changes.

Checklist

I have…

  • [ X] run the application locally (./scripts/serve) and verified that my changes behave as expected.
  • [ X] run the build process locally (./scripts/build) and make sure it builds correctly.
  • [X ] run the test suite (./scripts/test) and verified that all tests pass.
  • [X ] summarized below my changes and noted which issues (if any) this pull request fixes or addresses.
  • [ X] thoroughly outlined below the steps necessary to test my changes.
  • [ -] attached screenshots illustrating relevant behavior before and after my changes.
  • [ X] read, understand, and agree to the terms described in CONTRIBUTING.md.
  • [ -] added my name, email address, and copyright date to CONTRIBUTORS.md.

Summary of Changes

This pull request adds several json blocks for previously released/open-sourced code that was posted at @afrl-quantum.

Testing

To verify the changes proposed in this pull request, I used the ./scripts/serve script to ensure that the blocks were properly inserted into the aggregate code.json file.

"email": "[email protected]"
},
"openSourceProject": 1,
"governmentWideReuseProject": 1,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

code.mil uses version 2.0 of the code-dot-gov schema which includes openSource, governmentWideReuse in an array of ENUM's with usageType as its key. Please see https://github.com/GSA/code-gov-data/blob/master/schemas/schema-2.0.0.json

@david-saeger
Copy link
Contributor

Greetings, apologies for the delay in pulling these changes into code.mil. I reviewed these changesets and the only changes that need to be made to conform with version 2.0.0 of the code.gov code inventory schema is to add a usageType. In earlier versions of the spec these were boolean values which is how they are specified in these changesets. Please see https://github.com/GSA/code-gov-data/blob/master/schemas/schema-2.0.0.json

      "usageType": {
                "type": "string",
                "description": "A list of enumerated values which describes the usage permissions for the release: (1) openSource: Open source; (2) governmentWideReuse: Government-wide reuse; (3) exemptByLaw: The sharing of the source code is restricted by law or regulation, including—but not limited to—patent or intellectual property law, the Export Asset Regulations, the International Traffic in Arms Regulation, and the Federal laws and regulations governing classified information; (4) exemptByNationalSecurity: The sharing of the source code would create an identifiable risk to the detriment of national security, confidentiality of Government information, or individual privacy; (5) exemptByAgencySystem: The sharing of the source code would create an identifiable risk to the stability, security, or integrity of the agency’s systems or personnel, (6) exemptByAgencyMission: The sharing of the source code would create an identifiable risk to agency mission, programs, or operations; (7) exemptByCIO: The CIO believes it is in the national interest to exempt sharing the source code; (8) exemptByPolicyDate: The release was created prior to the M-16-21 policy (August 8, 2016)",
                "enum": [
                  "openSource",
                  "governmentWideReuse",
                  "exemptByLaw",
                  "exemptByNationalSecurity",
                  "exemptByAgencySystem",
                  "exemptByAgencyMission",
                  "exemptByCIO",
                  "exemptByPolicyDate"
                ],
                "additionalProperties": false
              },

It should be a relatively small change. I'll pull this in once completed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants