Ot.past donations #11
Conversation
|
I put UNFULFILLED/FULFILLED as the status but will work the same if it is: requested, processing, in delivery, or received |
CerberusLatrans
requested review from
fanzzz368,
nadishiro17,
sam-schu and
hellolol2016
| @@ -21,7 +21,6 @@ export class DonationsController { | |||
|
|
|||
| @Get('orders') | |||
| filter(@Body() filterDonationsDto: FilterDonationsDto) { | |||
There was a problem hiding this comment.
I think it's better to replace the @Body() with @query() because we usually do @query() with GET requests and @Body with POST or PUT
https://dev.to/shameel/nestjs-request-param-body-query-headers-ip-5e6k
There was a problem hiding this comment.
do you mean instead of using a FilterDonationsDto to put all of the filter conditions in the url to use @query?
| IsEnum, | ||
| IsInt, | ||
| IsOptional, | ||
| } from 'class-validator'; | ||
| import { DonationStatus } from '../types'; | ||
| import { Timestamp } from 'typeorm'; | ||
|
|
||
| export class FilterDonationsDto { | ||
| @IsDateString() |
There was a problem hiding this comment.
Do @isdate() instead to match with the Date types in DTO
There was a problem hiding this comment.
I tried this and it broke. Is there anything wrong with isDateString?
|
|
||
| @Get(':id') | ||
| findOne(@Param('id') id: string) { | ||
| return this.donationsService.findOne(+id); |
There was a problem hiding this comment.
converts to number representation of id
https://en.wikibooks.org/wiki/JavaScript/Operators#Arithmetic_operators
ℹ️ Issue
Closes
📝 Description
Gives ability to fetch donation orders and filter by due date start, due date end, a list of pantry ids, and status (FULFILLED/UNFULFILLED). All the filter conditions are optional, so all nulls will fetch all orders.
✔️ Verification
Sent requests via postman to test inclusion/exclusion of dates, pantry ids, and status (including all nulls).
Provide screenshots of any new components, styling changes, or pages.
